New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-1399] Refactor automatic interpreter name insert #1388
Conversation
Tested and LGTM. |
@minahlee For the first case, it is actually the default interpreter. Another example would be using: |
@corneadoug actually I made it empty intentionally. please check out the discussion here |
@minahlee Making a new line is a good improvement because some interpreters do not handle same line typing. For removing the default interpreter, I don't have a strong opinion. However it could feel weird to have Release 0.6.1 have the default interpreter shown, 0.6.2 not showing it, then 0.6.3 or 0.7.0 have Interpreter always shown again but this time as part of the paragraph (not in text editor) |
I totally agree that we shouldn't make ux change often. But showing default interpreter in text is implemented only in master branch but not in previous release so I think it won't bring much of confusion. |
cb7e83c
to
e8f3542
Compare
954127f
to
5313f13
Compare
…ong interpreter name" This reverts commit b89e35e.
5313f13
to
6c035d9
Compare
CI is green. Merge if there is no more discussuion |
What is this PR for?
Refine automatic interpreter name insert. See below jira issue for detailed description
What type of PR is it?
Improvement | Refactoring
What is the Jira issue?
ZEPPELIN-1399
Screenshots (if appropriate)
Before
After
Before
After
Questions: