-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-1446] Fix broken layout of Create new interpreter
UI.
#1431
Conversation
@astroshim Good catch and looks better! |
@AhyoungRyu Thank you for your kind review. I just fix the space. |
Could we maybe try to keep the same spacing style as the interpreter edit? Interpreter Edit:Interpreter Create: |
@corneadoug Actually I did that work in here... :) |
@AhyoungRyu I was talking about the spacing below |
Thank you @AhyoungRyu and @corneadoug . |
@corneadoug Ah I got it. I'll do the same work as @astroshim did in my PR then :D |
Tested LGTM |
I rebased but build failed. |
re-build CI |
re-build CI |
CI is green now! LGTM 👍 |
Merging if there is no more discussions |
### What is this PR for? This PR fixes broken layout of `Create new interpreter` UI. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1446 ### How should this be tested? - Try to create new interpreter on the Interpreters menu. ### Screenshots (if appropriate) - before ![image](https://cloud.githubusercontent.com/assets/3348133/18592384/b3bfe120-7c71-11e6-80c2-31d0b4363009.png) - after ![image](https://cloud.githubusercontent.com/assets/3348133/18592410/c777aef0-7c71-11e6-9379-9b424823fbed.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: astroshim <hsshim@nflabs.com> Closes apache#1431 from astroshim/ZEPPELIN-1446 and squashes the following commits: 729215b [astroshim] Merge branch 'master' into ZEPPELIN-1446 69cc1a0 [astroshim] Merge branch 'master' into ZEPPELIN-1446 fada36b [astroshim] fix spaces 2d3ec76 [astroshim] fix space 5f0a461 [astroshim] fix align checkboxs.
What is this PR for?
This PR fixes broken layout of
Create new interpreter
UI.What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1446
How should this be tested?
Screenshots (if appropriate)
Questions: