Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-1605] zeppelin-interpreter: don't publish shaded JAR on maven central #1661

Closed
wants to merge 1 commit into from

Conversation

minahlee
Copy link
Member

@minahlee minahlee commented Nov 21, 2016

What is this PR for?

  • Instead of creating fat jar for zeppelin-interpreter and add it to classpath, place zeppelin-interpreter.jar and dependencies under lib/interpreter directory and add this dir to classpath of zeppelin-server and interpreter. (removed maven-shade-plugin)
  • Exclude some transitive dependencies from zeppelin-zengine which cause conflicts with those of zeppelin-interpreter
  • Exclude configuration files(credential.json, notebook-authorization.json, shiro.ini) when create binary package.

What type of PR is it?

Improvement

What is the Jira issue?

ZEPPELIN-1605

How should this be tested?

  1. Check if interpreter directory has created under zeppelin-distribution/target/zeppelin-0.7.0-SNAPSHOT/zeppelin-0.7.0-SNAPSHOT/
  2. Test md interpreter works as expected after running below command:
$ mvn clean package -DskipTests -Pbuild-distr
$ cd zeppelin-distribution/target/zeppelin-0.7.0-SNAPSHOT/zeppelin-0.7.0-SNAPSHOT
$ ./bin/zeppelin-daemon.sh start
  1. Check if md intepreter process has zeppelin-distribution/target/zeppelin-0.7.0-SNAPSHOT/zeppelin-0.7.0-SNAPSHOT/lib/interpreter/* in it's classpath.

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@bzz
Copy link
Member

bzz commented Dec 1, 2016

@minahlee Looks great to me!

Could you please rebase on latest master? It looks like there are a few conflicts now

I assume that for testing, it should be enough to build mvn clean package -Pbuild-distr -DskipTests and make sure Zeppelin run from zeppelin-distribution/target is able to execute a paragraph, or is there a better way?

@minahlee
Copy link
Member Author

minahlee commented Dec 2, 2016

@bzz Thank you for review, I just rebased. And yes, the way you described is correct way to test this PR, I updated it in description.

@minahlee minahlee force-pushed the ZEPPELIN-1605 branch 3 times, most recently from 2dc0b29 to 977fa18 Compare December 3, 2016 05:24
@bzz
Copy link
Member

bzz commented Dec 5, 2016

Sounds awesome, thank you!

Let's merge then, if there is no further discussion.

@asfgit asfgit closed this in a10545b Dec 11, 2016
@minahlee minahlee deleted the ZEPPELIN-1605 branch March 6, 2017 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants