[ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut

[soralee]

What is this PR for?

Currently, keyboard shortcuts can be only seen by keyboard icon.
It'll be very comfortable if keyboard shortcuts are showing the menu of paragraph.

What type of PR is it?

[Improvement]

Todos

• Add the keyboard shortcut of Link this paragraph
• Update CI(Selelium) Test case

What is the Jira issue?

• https://issues.apache.org/jira/browse/ZEPPELIN-1757

How should this be tested?

Click to paragraph menu. I tested on Ubuntu.

Screenshots (if appropriate)

[before]

[after]

Questions:

• Does the licenses files need update? No
• Is there breaking changes for older versions? No
• Does this needs documentation? No

[astroshim]

@soralee Thank you for contribution of useful function.
but I am usually using the Shift + Enter to run paragraph,
How can be presented this shortcut?
and it seems necessary a shortcut for the Link this paragraph. What do you think?

[soralee]

@astroshim Thanks for suggestion.
The shortcut key of Run this paragraph is being presented by tooltip already.

BTW, I agree the shortcut key of Link this paragraph seems to be necessary. I'll improve shortcut key and will fix CI in order to be green light.

[AhyoungRyu]

@soralee Regarding ParagraphActionsIT.java change, IMO it would be better to be handled by another PR so that we can only focus on the scope of this patch. There are already many issues related ParagraphActionsIT.java as Flaky Test category(see here). If this change that you made can fix the problem then we can merge it first and then you can rebase based on the latest master.

[soralee]

@AhyoungRyu I appreciate to your information!
I think I already fixed ParagraphActionsIT.java file. But, each time I tested the CI, the build operation failed differently. So I just wondered that.
Let me do the rebase and test again.

[soralee]

Regarding Link this paragraph shortcut key, I just created this issue. (#1756)
If that issue (#1756) merged, Let me update this feature.

[soralee]

I updated description of PR as like below.

• add shortcut key to tooltip (cancel to run paragraph, toggle editor, toggle output)
• add shortcut key to Link this paragraph in paragraph menu

[soralee]

Ping Ping ! Ci is green.
It's time to ready to review this PR 😄

[Leemoonsoo]

This is screenshot i got from this branch.

I'm not sure why some items are missing and text are not aligned. @soralee Could you check?

[soralee]

Sure! Let me check and test again 😃
Thanks for test @Leemoonsoo

[soralee]

@Leemoonsoo I fixed the problem regarding not aligned text.
Could you test and check again, please?

[Leemoonsoo]

Tested again. And still not every items are displayed

@soralee could you check?

[soralee]

Sorry, I've missed your review @Leemoonsoo
If your note has only one paragraph and you checked that menu of paragraph, it normally works like your screenshot. Because that paragraph doesn't need some function like Move up and Move down and Remove.
If you want to see all item, could you check middle paragraph menu after making three paragraph?

[Leemoonsoo]

@soralee you're right. I checked again and it looks good to me.
Thanks for the improvement and merge if there're no further comments!