[ZEPPELIN-1804] Added Link this paragraph to keyboard shortcut #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
soralee
changed the title
soralee
force-pushed
the
ZEPPELIN-1804
branch
2 times, most recently
from
48b225b
to
750f5e4
Compare
|
OMG hope that it passes this time... :) |
|
@tae-jun Sorry for many reopened PR. |
soralee
force-pushed
the
ZEPPELIN-1804
branch
from
750f5e4
to
def8519
Compare
|
Tested and LGTM. |
soralee
force-pushed
the
ZEPPELIN-1804
branch
4 times, most recently
from
3863216
to
b6f5453
Compare
soralee
force-pushed
the
ZEPPELIN-1804
branch
from
b6f5453
to
92d2a44
Compare
|
Finally, the CI is GREEN! (After about 7 attempts) 😭 |
|
At last! Tested and it works well. LGTM 👍 |
|
@Leemoonsoo @AhyoungRyu Thanks for review :) |
|
Merge to master if there're no more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Each paragraph menu, it has "Link this paragraph" function which is link each of the paragraph but there is not shortcut key.
What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1804
How should this be tested?
Please press Ctrl+Alt+w shortcut key and check work as expected well
Screenshots (if appropriate)
Questions: