Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] fix: DON'T run npm clean in maven clean phase (CI related, Build failure in web) #1841

Closed

Conversation

1ambda
Copy link
Member

@1ambda 1ambda commented Jan 4, 2017

What is this PR for?

maven clean executes npm run clean after #1824. but running npm commands requires installing, it's impossible to clean before installing it.

This PR resolve CI break (see broken RAT build profiles)

What type of PR is it?

[Bug Fix | Hot Fix]

Todos

Nothing

What is the Jira issue?

ZEPPELIN-1850

How should this be tested?

The first build profile (RAT) should pass CI.

Screenshots (if appropriate)

[INFO] --- frontend-maven-plugin:1.3:npm (npm clean) @ zeppelin-web ---
...
[INFO] Running 'npm run clean' in /Users/lambda/github/apache-zeppelin/zeppelin-bug/zeppelin-web
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.701 s
[INFO] Finished at: 2017-01-05T03:55:32+09:00
[INFO] Final Memory: 21M/982M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm clean) on project zeppelin-web: Failed to run task: 'npm run clean' failed. java.io.IOException: Cannot run program"/Users/lambda/github/apache-zeppelin/zeppelin-bug/zeppelin-web/node/node" (in directory "/Users/lambda/github/apache-zeppelin/zeppelin-bug/zeppelin-web"): error=2, No such file or directory -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm clean) on project zeppelin-web: Failed to run task
...
 
[ERROR]
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@1ambda 1ambda changed the title [ZEPPELIN-1850] fix: DON'T run npm clean in maven clean phase (CI related) [HOTFIX] fix: DON'T run npm clean in maven clean phase (CI related, Build failure in web) Jan 4, 2017
@1ambda 1ambda force-pushed the fix/invalid-clean-setting-in-zeppelin-web branch from fba3086 to 4f83de1 Compare January 4, 2017 20:34
@Leemoonsoo
Copy link
Member

LGTM. It fixes CI build failure. Merge to master as a hotfix

@asfgit asfgit closed this in 4723c88 Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants