Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] fix: DON'T run npm clean in maven clean phase (CI related, Build failure in web) #1841

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 13 additions & 11 deletions zeppelin-web/pom.xml
Expand Up @@ -146,17 +146,6 @@
</configuration>
</execution>

<execution>
<id>npm clean</id>
<goals>
<goal>npm</goal>
</goals>
<phase>clean</phase>
<configuration>
<arguments>run clean</arguments>
</configuration>
</execution>

</executions>
</plugin>

Expand Down Expand Up @@ -186,6 +175,19 @@
<plugin>
<!-- clean task will be executed by front-end-maven plugin -->
<artifactId>maven-clean-plugin</artifactId>
<configuration>
<filesets>
<fileset>
<directory>bower_components</directory>
</fileset>
<fileset>
<directory>node</directory>
</fileset>
<fileset>
<directory>node_modules</directory>
</fileset>
</filesets>
</configuration>
</plugin>
</plugins>
</build>
Expand Down