[MINOR] Small Selenium test fixes #1882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused imports; Replace "Thread.sleep" (unstable solution); Add "deleteTestNotebook()" method -> testWidth.
|
@bitchelov Thanks for making selenium test more stable! LGTM and merge to master if no more discussions. |
asfgit
pushed a commit
that referenced
this pull request
Jan 12, 2017
### What is this PR for? Remove unused imports; Replace "Thread.sleep" (unstable solution); Add "deleteTestNotebook()" method -> testWidth. ### What type of PR is it? [Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Travis-CI ### Screenshots (if appropriate) https://travis-ci.org/apache/zeppelin/builds/190644901 -> https://travis-ci.org/apache/zeppelin/jobs/190644918 ### Questions: * Does the licenses files need update? (no) * Is there breaking changes for older versions? (no) * Does this needs documentation? (no) Author: Unknown <Sokurito@gmail.com> Closes #1882 from bitchelov/automationTestFix and squashes the following commits: f898c59 [Unknown] [MINOR] Small Selenium test fixes (cherry picked from commit 4342156) Signed-off-by: Jongyoul Lee <jongyoul@apache.org>
|
Merged it into master and branch-0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Remove unused imports;
Replace "Thread.sleep" (unstable solution);
Add "deleteTestNotebook()" method -> testWidth.
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Travis-CI
Screenshots (if appropriate)
https://travis-ci.org/apache/zeppelin/builds/190644901 -> https://travis-ci.org/apache/zeppelin/jobs/190644918
Questions: