Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-1976] Text-Output too large, causing crash #1908

Closed
wants to merge 2 commits into from

Conversation

Leemoonsoo
Copy link
Member

What is this PR for?

This PR implements interpreter output message limit.

ZEPPELIN_INTERPRETER_OUTPUT_LIMIT env variable or zeppelin.interpreter.output.limit jvm property can set limit of the interpreter output message in byte.

The limit applied to only TEXT and TABLE type output, not in HTML or other types.

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1976

How should this be tested?

try to print more than the limit

%spark
(1 to 10000).foreach(i=>
    println(s"Print line ${i} times")
)

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

<property>
<name>zeppelin.interpreter.output.limit</name>
<value>102400</value>
<description>Output message from interpreter exceed the limit will be truncated</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exceeding the limit?

@Leemoonsoo
Copy link
Member Author

Merge to master when no more discussions

@asfgit asfgit closed this in 14d13de Jan 23, 2017
asfgit pushed a commit that referenced this pull request May 24, 2017
This PR implements interpreter output message limit.

`ZEPPELIN_INTERPRETER_OUTPUT_LIMIT` env variable or `zeppelin.interpreter.output.limit` jvm property can set limit of the interpreter output message in byte.

The limit applied to only TEXT and TABLE type output, not in HTML or other types.

Improvement

* [x] - Task

https://issues.apache.org/jira/browse/ZEPPELIN-1976

try to print more than the limit
```
%spark
(1 to 10000).foreach(i=>
    println(s"Print line ${i} times")
)
```

![image](https://cloud.githubusercontent.com/assets/1540981/22035334/6c17ff9a-dca4-11e6-89b0-51b9340856b0.png)

* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes #1908 from Leemoonsoo/ZEPPELIN-1976 and squashes the following commits:

639868b [Lee moon soo] update description
a9b4139 [Lee moon soo] Truncate output

(cherry picked from commit 14d13de)
Signed-off-by: Mina Lee <minalee@apache.org>
@BruceXu1991
Copy link

This PR limit the output of paragraph in web, however it also limit the max download lines.

My suggestion is to limit output of paragraph through zeppelin.interpreter.output.limit and limit the number of download lines through common.max_count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants