[ZEPPELIN-1968] Added property to disable hive user impersonation #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI passed all the tests : https://travis-ci.org/gfalcone/zeppelin |
|
This looks OK to me, can you add a line note on https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md#apache-hive to update the documentation. |
|
@prabhjyotsingh thank you for reviewing, just pushed the documentation :) |
| @@ -374,16 +374,22 @@ public Connection getConnection(String propertyKey, InterpreterContext interpret | |||
| if (lastIndexOfUrl == -1) { | |||
| lastIndexOfUrl = connectionUrl.length(); | |||
| } | |||
| connectionUrl.insert(lastIndexOfUrl, ";hive.server2.proxy.user=" + user + ";"); | |||
| if (!property.getProperty("hive.proxy.user").equals("false")){ | |||
There was a problem hiding this comment.
Just realised, can you do a null check for this, if the property key doesn't exists, this will throw NPE.
|
@prabhjyotsingh right, didn't see that |
|
@prabhjyotsingh is everything good for you :) ? |
|
Yes, LGTM! |
|
Merging this if no more discussion. |
| try { | ||
| ugi = UserGroupInformation.createProxyUser(user, | ||
| UserGroupInformation.getCurrentUser()); | ||
| ugi = property.getProperty("hive.proxy.user").equals("false") ? |
There was a problem hiding this comment.
NPE check need to be applied here as well. Missed this last time.
|
@prabhjyotsingh OK, so I deleted that line because I realized that we were in the condition where it's not the hive jdbc, so we don't have to worry about that. |
|
Sure thank you @gfalcone, will merge this soon. |
|
@prabhjyotsingh the CI passed ! |
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Sep 1, 2017
### What is this PR for? Added new property "hive.proxy.user" to disable hive impersonation (on some clusters, this option is disabled) in order to make Hive Interpreter even without this ### What type of PR is it? Feature ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1968 ### How should this be tested? Set "hive.proxy.user" to true in the jdbc interpreter setttings, and you should see "Using hive proxy user" in the jdbc logs. If "hive.proxy.user" has another value, this is not mentionned in the logs You can also test with the appropriate hive configuration, but this could take longer :) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes Author: Paolo Genissel <paolo.genissel-monsallier@1000mercis.com> Closes apache#2051 from gfalcone/hive_impersonation and squashes the following commits: a39d11c [Paolo Genissel] Fixed last NPE 1f7f685 [Paolo Genissel] Fixed NPE when getting hive.proxy.user property 433eefb [Paolo Genissel] Added documentation for feature d6f0c62 [Paolo Genissel] Added property to disable hive user impersonation
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Oct 23, 2017
### What is this PR for? Added new property "hive.proxy.user" to disable hive impersonation (on some clusters, this option is disabled) in order to make Hive Interpreter even without this ### What type of PR is it? Feature ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1968 ### How should this be tested? Set "hive.proxy.user" to true in the jdbc interpreter setttings, and you should see "Using hive proxy user" in the jdbc logs. If "hive.proxy.user" has another value, this is not mentionned in the logs You can also test with the appropriate hive configuration, but this could take longer :) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes Author: Paolo Genissel <paolo.genissel-monsallier@1000mercis.com> Closes apache#2051 from gfalcone/hive_impersonation and squashes the following commits: a39d11c [Paolo Genissel] Fixed last NPE 1f7f685 [Paolo Genissel] Fixed NPE when getting hive.proxy.user property 433eefb [Paolo Genissel] Added documentation for feature d6f0c62 [Paolo Genissel] Added property to disable hive user impersonation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Added new property "hive.proxy.user" to disable hive impersonation (on some clusters, this option is disabled) in order to make Hive Interpreter even without this
What type of PR is it?
Feature
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1968
How should this be tested?
Set "hive.proxy.user" to true in the jdbc interpreter setttings, and you should see "Using hive proxy user" in the jdbc logs.
If "hive.proxy.user" has another value, this is not mentionned in the logs
You can also test with the appropriate hive configuration, but this could take longer :)
Screenshots (if appropriate)
Questions: