Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-2430] The xAxis text in the line and area chart overlaps #2339

Closed

Conversation

soralee
Copy link
Contributor

@soralee soralee commented May 12, 2017

What is this PR for?

Like in the #2133 case, the xAxis text of area chart and line chart is overlapping.
For reusing form, I created a html template file for how to show xLabel and, in rotate button checked, show up input box for set value of rotate degree (default value is -45).

What type of PR is it?

[Bug Fix | Improvement]

What is the Jira issue?

How should this be tested?

  1. Click settings button in the barChart
  2. Check to whether there are default, rotate, hide button or not.
  3. Test to click each button and whether it works well or not for each situation.
  4. In rotate button checked, check to set value and showing xAixs rotate degree properly.
  5. In the areaChart and lineChart, test with above steps.

Screenshots (if appropriate)

[Before]
image

image

[After]
z_overlap_in_text

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@soralee
Copy link
Contributor Author

soralee commented May 12, 2017

CI fail is irrelevant this PR.

Tests in error: 
  SecurityRestApiTest.testGetUserList:69 » JsonSyntax java.lang.IllegalStateExce...
  SecurityRestApiTest.testTicket:55 » JsonSyntax java.lang.IllegalStateException...
Tests run: 58, Failures: 5, Errors: 2, Skipped: 1

Hide
</button>
</div>`,
template: `<ng-include src="'app/visualization/builtins/visualization-dispayXAxis.html'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template field understand URL. Could you try it without 'ng-include'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh,I didn't know that. I'll update it.
Thanks!

@soralee soralee force-pushed the ZEPPELIN-2430_overlap_line_area branch from 3f500e3 to e8e2e39 Compare May 15, 2017 10:01
@soralee
Copy link
Contributor Author

soralee commented May 15, 2017

I removed ng-include in bar chart and area char. the ng-include in line chart couldn't remove now because there are other html source. (I think to improve a logic is other problem.)
@moon, could you review again?

@Leemoonsoo
Copy link
Member

LGTM and merge to master if no further comments.

@soralee
Copy link
Contributor Author

soralee commented May 16, 2017

@asfgit asfgit closed this in fcd3aa7 May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants