[ZEPPELIN-3321] isRevisionSupported not working for importing notebooks. #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prabhjyotsingh please add a test |
Change-Id: I2ba8a49b79ae94212046933ee74d8fafb3a387bb
|
LGTM |
1 similar comment
|
LGTM |
|
Thanks for the review will merge this if no more discussion. |
asfgit
pushed a commit
that referenced
this pull request
Mar 15, 2018
when importing note of from one zeppelin instance that don't support revision to another zeppelin instance where revision is supported, the imported note still don't support revision. [Bug Fix] * [ZEPPELIN-3321](https://issues.apache.org/jira/browse/ZEPPELIN-3321) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes #2862 from prabhjyotsingh/ZEPPELIN-3321 and squashes the following commits: eca6b59 [Prabhjyot Singh] add unit test for isRevisionSupported 552fdeb [Prabhjyot Singh] approach 2: set as isRevisionSupported zeppelin global config 18873d3 [Prabhjyot Singh] ZEPPELIN-3321: fix isRevisionSupported Change-Id: I49ec3350303b39a41b769bc47941c3397160234c (cherry picked from commit 6001b98) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com>
jwagun
pushed a commit
to jwagun/zeppelin
that referenced
this pull request
Apr 23, 2018
when importing note of from one zeppelin instance that don't support revision to another zeppelin instance where revision is supported, the imported note still don't support revision. [Bug Fix] * [ZEPPELIN-3321](https://issues.apache.org/jira/browse/ZEPPELIN-3321) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2862 from prabhjyotsingh/ZEPPELIN-3321 and squashes the following commits: eca6b59 [Prabhjyot Singh] add unit test for isRevisionSupported 552fdeb [Prabhjyot Singh] approach 2: set as isRevisionSupported zeppelin global config 18873d3 [Prabhjyot Singh] ZEPPELIN-3321: fix isRevisionSupported Change-Id: I49ec3350303b39a41b769bc47941c3397160234c
prabhjyotsingh
added a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Jul 4, 2018
when importing note of from one zeppelin instance that don't support revision to another zeppelin instance where revision is supported, the imported note still don't support revision. [Bug Fix] * [ZEPPELIN-3321](https://issues.apache.org/jira/browse/ZEPPELIN-3321) * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2862 from prabhjyotsingh/ZEPPELIN-3321 and squashes the following commits: eca6b59 [Prabhjyot Singh] add unit test for isRevisionSupported 552fdeb [Prabhjyot Singh] approach 2: set as isRevisionSupported zeppelin global config 18873d3 [Prabhjyot Singh] ZEPPELIN-3321: fix isRevisionSupported Change-Id: I49ec3350303b39a41b769bc47941c3397160234c (cherry picked from commit 6001b98) Signed-off-by: Prabhjyot Singh <prabhjyotsingh@gmail.com> (cherry picked from commit 257db1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
when importing note of from one zeppelin instance that don't support revision to another zeppelin instance where revision is supported, the imported note still don't support revision.
What type of PR is it?
[Bug Fix]
What is the Jira issue?
Questions: