[zeppelin-3639] Add Ipython interpreter prerequisite check for protobuf #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Would be nice to check freeze output for tornado version. |
felixcheung
approved these changes
Jul 20, 2018
|
@Tagar thanks for suggestion, but I think it's better not to include this check for tornado in this function since it's not really pre-requisite check. if we add it, then we need to keep track of it, and restore back when the issue with tornado is fixed. |
|
that makes sense. thanks @khalidhuseynov |
asfgit
pushed a commit
that referenced
this pull request
Aug 2, 2018
This is to protobuf prerequisite check when starting ipython kernel. This is required since from grpcio 1.12.0 it's independent from protobuf [ Improvement ] * [x] - add protobuf prerequisite check * [x] - add to ipython docs https://issues.apache.org/jira/browse/ZEPPELIN-3639 1. remove grpcio and protobuf 2. install latest grpcio and try to run ipython interpreter - should fail 3. then install protobuf and try again - should work * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Khalid Huseynov <khalidhnv@gmail.com> Closes #3084 from khalidhuseynov/fix/ZEPPELIN-3639 and squashes the following commits: 066e061 [Khalid Huseynov] fix ipython documentation 58c0689 [Khalid Huseynov] add protobuf prerequsite check (cherry picked from commit c95d896) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
### What is this PR for? This is to protobuf prerequisite check when starting ipython kernel. This is required since from grpcio 1.12.0 it's independent from protobuf ### What type of PR is it? [ Improvement ] ### Todos * [x] - add protobuf prerequisite check * [x] - add to ipython docs ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3639 ### How should this be tested? 1. remove grpcio and protobuf 2. install latest grpcio and try to run ipython interpreter - should fail 3. then install protobuf and try again - should work ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Khalid Huseynov <khalidhnv@gmail.com> Closes apache#3084 from khalidhuseynov/fix/ZEPPELIN-3639 and squashes the following commits: 066e061 [Khalid Huseynov] fix ipython documentation 58c0689 [Khalid Huseynov] add protobuf prerequsite check
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
This is to protobuf prerequisite check when starting ipython kernel. This is required since from grpcio 1.12.0 it's independent from protobuf [ Improvement ] * [x] - add protobuf prerequisite check * [x] - add to ipython docs https://issues.apache.org/jira/browse/ZEPPELIN-3639 1. remove grpcio and protobuf 2. install latest grpcio and try to run ipython interpreter - should fail 3. then install protobuf and try again - should work * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Khalid Huseynov <khalidhnv@gmail.com> Closes apache#3084 from khalidhuseynov/fix/ZEPPELIN-3639 and squashes the following commits: 066e061 [Khalid Huseynov] fix ipython documentation 58c0689 [Khalid Huseynov] add protobuf prerequsite check (cherry picked from commit c95d896) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is to protobuf prerequisite check when starting ipython kernel. This is required since from grpcio 1.12.0 it's independent from protobuf
What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3639
How should this be tested?
Screenshots (if appropriate)
Questions: