[ZEPPELIN-3943] - Add button "stop notebook execution" #3281
Conversation
| tooltip-placement="bottom" | ||
| uib-tooltip="Stop execution" | ||
| ng-disabled="revisionView"> | ||
| <i class="icon-control-pause"></i> |
There was a problem hiding this comment.
that's a pause icon - is there a stop icon?
There was a problem hiding this comment.
simple-line-icons.css not contains 'stop' button. Therefore, I used 'icon-control-pause'.
In paragraph-control.html 'icon-control-pause' is also used to stop a paragraph.
| } | ||
| } catch (IOException e) { | ||
| LOGGER.error("Can't run paragraph", e); |
There was a problem hiding this comment.
does this get reported to the user in the frontend?
There was a problem hiding this comment.
I think not worth it. Since if something goes wrong during the start of a paragraph, then an error message will be displayed in the paragraph.
|
|
||
| for (Paragraph paragraph : note.getParagraphs()) { | ||
| if (paragraph.isRunning()) { | ||
| paragraph.abort(); |
There was a problem hiding this comment.
is there a race condition? since runParagraph is a loop, what if we abort para 1 but there threadpool thread runs para 2?
There was a problem hiding this comment.
@felixcheung, i fixed it.
Savalek
force-pushed
the
ZP-54
branch
2 times, most recently
from
f93e305
to
49f4dfa
Compare
| @@ -86,6 +86,7 @@ | |||
|
|
|||
| /********************************** transient fields ******************************************/ | |||
| private transient boolean loaded = false; | |||
| private transient boolean executionAborted = false; | |||
There was a problem hiding this comment.
oh, it's non-volatile object. It doesnt looks like thread safe code.
You should use volatile w synchronized or something like java.util.concurrent.atomic.AtomicBoolean.
| if (note.isExecutionAborted() || !runParagraph(noteId, paragraphId, title, text, | ||
| params, config, false, true, context, callback)) { | ||
| // stop execution when one paragraph fails. | ||
| break; |
There was a problem hiding this comment.
I think this is duplicated with Note#runAll
There was a problem hiding this comment.
@zjffdu, i did a little refactoring. And left only one method to run several paragraphs.
|
Thanks @Savalek LGTM |
What is this PR for?
This PR add opportunity to stop notebook execution.
PR type:
ImprovementJira issue:
ZEPPELIN-3943Questions: