Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZEPPELIN-5786] Remove sap interpreter #4437

Merged
merged 3 commits into from Aug 2, 2022
Merged

[ZEPPELIN-5786] Remove sap interpreter #4437

merged 3 commits into from Aug 2, 2022

Conversation

kkoldduck2
Copy link
Contributor

@kkoldduck2 kkoldduck2 commented Jul 28, 2022 •
edited

What is this PR for?

Remove sap interpreter which is not used frequently

What type of PR is it?

Refactoring

Todos

  • - Remove sap and related things

What is the Jira issue?

ZEPPELIN-5786

How should this be tested?

  • CI

Screenshots (if appropriate)

Questions:

  • Does the licenses files need to update? Yes, Edited
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Yes, Edited

@kkoldduck2 kkoldduck2 changed the title Remove sap interpreter [ZEPPELIN-5786] Remove sap interpreter Jul 28, 2022
@jongyoul jongyoul merged commit bdb7f3f into apache:master Aug 2, 2022
HYEEWON
HYEEWON reviewed Aug 3, 2022
View reviewed changes
zeppelin-web/package.json
@@ -93,7 +93,7 @@
"postcss-loader": "^3.0.0",
"protractor": "^5.4.1",
"raw-loader": "^0.5.1",
"rimraf": "^3.0.2",
"rimraf": "^2.5.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I have a question about this pr.
Can you tell me why you downgraded the version of rimraf?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh? I missed this thing. I also wonder why.

Copy link
Contributor Author

@kkoldduck2 kkoldduck2 Aug 4, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm so sorry.. it's 3.0.2 version on my local but it's changed somehow, I don't know why.. May be there was a mistake when I made PR. Should I revert this pr??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm so sorry.. it's 3.0.2 version on my local but it's changed somehow, I don't know why.. May be there was a mistake when I made PR. Should I revert this pr??

I only updated rimraf version to 3.0.2 on master branch, but not on my branch 'remove_sap'. There was mistake when I made PR. If I should revert this pr, please let me know and I'll do it.

Copy link
Contributor

@HYEEWON HYEEWON Aug 10, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change this. Because, the version was updated in pr #4414.

@kkoldduck2 kkoldduck2 mentioned this pull request Aug 25, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYEEWON HYEEWON HYEEWON left review comments

@jongyoul jongyoul Awaiting requested review from jongyoul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kkoldduck2 @jongyoul @HYEEWON