Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-5802][MINOR] fix rimraf version #4448

Merged
merged 2 commits into from
Aug 25, 2022
Merged

[ZEPPELIN-5802][MINOR] fix rimraf version #4448

merged 2 commits into from
Aug 25, 2022

Conversation

kkoldduck2
Copy link
Contributor

What is this PR for?

In the [ZEPPELIN-5786] Remove sap interpreter pr, the rimraf version overrided from 3.0.2 to 2.5.4 unintentionally.
Therefore it needs to be fixed back to 3.0.2 version.

What type of PR is it?

Bug Fix

Todos

  • - fix rimraf version to 3.0.2

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5802

How should this be tested?

  • CI

Screenshots (if appropriate)

Questions:

  • Does the licenses files need to update? N
  • Is there breaking changes for older versions? N
  • Does this needs documentation? N

Copy link
Contributor

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also a change in the zeppelin-web/package-lock.json. This should also be changed back.
Related PR: #4437

@jongyoul
Copy link
Member

@kkoldduck2 Could you please handle the review?

@kkoldduck2
Copy link
Contributor Author

There was also a change in the zeppelin-web/package-lock.json. This should also be changed back. Related PR: #4437

Oh! I will change it back too! thank you

@jongyoul jongyoul merged commit f297dbd into apache:master Aug 25, 2022
@jongyoul jongyoul self-assigned this Aug 25, 2022
@kkoldduck2 kkoldduck2 deleted the fix_rimraf branch August 26, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants