ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead

store to local variable (Hongchao Deng via rgs) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1685167 13f79535-47bb-0310-9956-ffa450edef68
apache · Jun 12, 2015 · 7288576 · 7288576
1 parent d54ca14
commit 7288576
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -199,6 +199,9 @@ IMPROVEMENTS:
   ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop
   (Akihiro Suda via rgs)
 
+  ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead
+  store to local variable (Hongchao Deng via rgs)
+
 Release 3.5.0 - 8/4/2014
 
 NEW FEATURES:

diff --git a/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java b/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
@@ -255,9 +255,8 @@ private void sendPackets() throws InterruptedException {
     }
 
     static public String packetToString(QuorumPacket p) {
-        String type = null;
+        String type;
         String mess = null;
-        Record txn = null;
 
         switch (p.getType()) {
         case Leader.ACK:
@@ -279,7 +278,7 @@ static public String packetToString(QuorumPacket p) {
             type = "PROPOSAL";
             TxnHeader hdr = new TxnHeader();
             try {
-                txn = SerializeUtils.deserializeTxn(p.getData(), hdr);
+                SerializeUtils.deserializeTxn(p.getData(), hdr);
                 // mess = "transaction: " + txn.toString();
             } catch (IOException e) {
                 LOG.warn("Unexpected exception",e);