ZOOKEEPER-3443: Add support of PKCS12 trust/key stores #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't go super deep into this but at a superficial glance, it seems pretty straightforward. Nice addition. |
eolivelli
requested changes
Jun 25, 2019
zookeeper-server/src/main/java/org/apache/zookeeper/common/StandardTypeFileKeyStoreLoader.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/main/java/org/apache/zookeeper/common/StandardTypeFileKeyStoreLoader.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509TestContext.java
Outdated
Show resolved
Hide resolved
ivanyu
force-pushed
the
ZOOKEEPER-3443
branch
4 times, most recently
from
ed2f6d7
to
dc763d6
Compare
|
I guess Travis Java 11 failure is related to #1005 |
This commit adds support of PKCS12 trust store and key store type. The existing mechanism for trust/key store types that support JKS and PEM were extended with PKCS12. The implementations of JKSFileLoader and PKCS12FileLoader were almost identical so most of it were abstracted away in StandardTypeFileKeyStoreLoader.
|
This is great. Thanks @ivanyu ! |
|
Thank you for the approval! |
asfgit
pushed a commit
that referenced
this pull request
Jul 15, 2019
This commit adds support of PKCS12 trust store and key store type. The existing mechanism for trust/key store types that support JKS and PEM were extended with PKCS12. The implementations of JKSFileLoader and PKCS12FileLoader were almost identical so most of it were abstracted away in StandardTypeFileKeyStoreLoader. Author: Ivan Yurchenko <ivanyu@aiven.io> Reviewers: eolivelli@apache.org, andor@apache.org Closes #1003 from ivanyu/ZOOKEEPER-3443 (cherry picked from commit 1c83846) Signed-off-by: Andor Molnar <andor@apache.org>
|
@ivanyu Merged to master and 3.5 branches, because it's relatively straightforward and part of Quorum TLS efforts. Thanks! |
|
Thank you! |
stickyhipp
pushed a commit
to stickyhipp/zookeeper
that referenced
this pull request
Aug 2, 2019
This commit adds support of PKCS12 trust store and key store type. The existing mechanism for trust/key store types that support JKS and PEM were extended with PKCS12. The implementations of JKSFileLoader and PKCS12FileLoader were almost identical so most of it were abstracted away in StandardTypeFileKeyStoreLoader. Author: Ivan Yurchenko <ivanyu@aiven.io> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1003 from ivanyu/ZOOKEEPER-3443
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
This commit adds support of PKCS12 trust store and key store type. The existing mechanism for trust/key store types that support JKS and PEM were extended with PKCS12. The implementations of JKSFileLoader and PKCS12FileLoader were almost identical so most of it were abstracted away in StandardTypeFileKeyStoreLoader. Author: Ivan Yurchenko <ivanyu@aiven.io> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1003 from ivanyu/ZOOKEEPER-3443
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
This commit adds support of PKCS12 trust store and key store type. The existing mechanism for trust/key store types that support JKS and PEM were extended with PKCS12. The implementations of JKSFileLoader and PKCS12FileLoader were almost identical so most of it were abstracted away in StandardTypeFileKeyStoreLoader. Author: Ivan Yurchenko <ivanyu@aiven.io> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1003 from ivanyu/ZOOKEEPER-3443
anmolnar
pushed a commit
to anmolnar/zookeeper
that referenced
this pull request
May 21, 2024
This commit adds support of PKCS12 trust store and key store type. The existing mechanism for trust/key store types that support JKS and PEM were extended with PKCS12. The implementations of JKSFileLoader and PKCS12FileLoader were almost identical so most of it were abstracted away in StandardTypeFileKeyStoreLoader. Author: Ivan Yurchenko <ivanyu@aiven.io> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1003 from ivanyu/ZOOKEEPER-3443 Change-Id: Ida22313eac4f69c1a678dc4ce0c7f7e329f1b2a0 (cherry picked from commit 979cb85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support of PKCS12 trust store and key store type.
The existing mechanism for trust/key store types that support JKS and
PEM were extended with PKCS12.
The implementations of JKSFileLoader and PKCS12FileLoader were almost
identical so most of it were abstracted away in
StandardTypeFileKeyStoreLoader.