ZOOKEEPER-2307:ZooKeeper not starting because acceptedEpoch is less than the currentEpoch #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han the currentEpoch
|
maoling
reviewed
Nov 20, 2019
|
|
||
| Assert.assertEquals("acceptedEpoch must not have changed", 0, | ||
| quorumPeer.getAcceptedEpoch()); | ||
| } |
There was a problem hiding this comment.
we also need assert currentEpoch here?
There was a problem hiding this comment.
if acceptedEpoch is 0 currentEpoch will be 0. But we can add assertion.
Added assertion for currentEpoch as well.
maoling
approved these changes
Nov 20, 2019
|
Refer to this link for build results (access rights to CI server needed): |
|
Merged to master. Thanks @arshadmohammad ! |
|
Hi, which version of zookeeper will have this fix? |
|
@rohitagl91 According to the jira: 3.6.0 |
|
Thanks @anmolnar.. and do we have expected release date of 3.6.0? |
|
RC1 is out. Feel free to vote for it. ;) |
junyoungKimGit
pushed a commit
to junyoungKimGit/zookeeper
that referenced
this pull request
Feb 7, 2020
…than the currentEpoch Update acceptedEpoch and currentEpoch in file first then in memory. Author: Mohammad Arshad <arshad@apache.org> Reviewers: andor@apache.org Closes apache#1145 from arshadmohammad/ZOOKEEPER-2307-epochUpdate and squashes the following commits: b05bc1f [Mohammad Arshad] review comment fix c8d620f [Mohammad Arshad] ZOOKEEPER-2307:ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
stickyhipp
pushed a commit
to stickyhipp/zookeeper
that referenced
this pull request
Aug 19, 2020
…than the currentEpoch Update acceptedEpoch and currentEpoch in file first then in memory. Author: Mohammad Arshad <arshad@apache.org> Reviewers: andor@apache.org Closes apache#1145 from arshadmohammad/ZOOKEEPER-2307-epochUpdate and squashes the following commits: b05bc1f [Mohammad Arshad] review comment fix c8d620f [Mohammad Arshad] ZOOKEEPER-2307:ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
symat
pushed a commit
to symat/zookeeper
that referenced
this pull request
Feb 24, 2021
…than the currentEpoch Update acceptedEpoch and currentEpoch in file first then in memory. Author: Mohammad Arshad <arshad@apache.org> Reviewers: andor@apache.org Closes apache#1145 from arshadmohammad/ZOOKEEPER-2307-epochUpdate and squashes the following commits: b05bc1f [Mohammad Arshad] review comment fix c8d620f [Mohammad Arshad] ZOOKEEPER-2307:ZooKeeper not starting because acceptedEpoch is less than the currentEpoch (cherry picked from commit 19d8567)
asfgit
pushed a commit
that referenced
this pull request
Feb 25, 2021
…than the currentEpoch Update acceptedEpoch and currentEpoch in file first then in memory. Author: Mohammad Arshad <arshadapache.org> Reviewers: andorapache.org Closes #1145 from arshadmohammad/ZOOKEEPER-2307-epochUpdate and squashes the following commits: b05bc1f [Mohammad Arshad] review comment fix c8d620f [Mohammad Arshad] ZOOKEEPER-2307:ZooKeeper not starting because acceptedEpoch is less than the currentEpoch (cherry picked from commit 19d8567) Author: Mohammad Arshad <arshad@apache.org> Reviewers: Andor Molnar <andor@apache.org>, Norbert Kalmar <nkalmar@apache.org> Closes #1613 from symat/ZOOKEEPER-4222
I think it wasn't fixed. I am running 3.6.1 got the same error "ERROR [main:QuorumPeer@1136] - Unable to load database on disk Is this resolved in 3.7 ? |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…than the currentEpoch Update acceptedEpoch and currentEpoch in file first then in memory. Author: Mohammad Arshad <arshad@apache.org> Reviewers: andor@apache.org Closes apache#1145 from arshadmohammad/ZOOKEEPER-2307-epochUpdate and squashes the following commits: b05bc1f [Mohammad Arshad] review comment fix c8d620f [Mohammad Arshad] ZOOKEEPER-2307:ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
…than the currentEpoch Update acceptedEpoch and currentEpoch in file first then in memory. Author: Mohammad Arshad <arshad@apache.org> Reviewers: andor@apache.org Closes apache#1145 from arshadmohammad/ZOOKEEPER-2307-epochUpdate and squashes the following commits: b05bc1f [Mohammad Arshad] review comment fix c8d620f [Mohammad Arshad] ZOOKEEPER-2307:ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update acceptedEpoch and currentEpoch in file first then in memory.