forked from apache/zookeeper
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ZOOKEEPER-2307: ZooKeeper not starting because acceptedEpoch is less …
…than the currentEpoch Update acceptedEpoch and currentEpoch in file first then in memory. Author: Mohammad Arshad <arshad@apache.org> Reviewers: andor@apache.org Closes apache#1145 from arshadmohammad/ZOOKEEPER-2307-epochUpdate and squashes the following commits: b05bc1f [Mohammad Arshad] review comment fix c8d620f [Mohammad Arshad] ZOOKEEPER-2307:ZooKeeper not starting because acceptedEpoch is less than the currentEpoch
- Loading branch information
1 parent
980df88
commit f5cd37a
Showing
3 changed files
with
177 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
152 changes: 152 additions & 0 deletions
152
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/EpochWriteFailureTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.zookeeper.server.quorum; | ||
|
|
||
| import static org.apache.zookeeper.test.ClientBase.CONNECTION_TIMEOUT; | ||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.util.Map; | ||
| import org.apache.zookeeper.CreateMode; | ||
| import org.apache.zookeeper.PortAssignment; | ||
| import org.apache.zookeeper.ZooDefs.Ids; | ||
| import org.apache.zookeeper.ZooKeeper; | ||
| import org.apache.zookeeper.test.ClientBase; | ||
| import org.apache.zookeeper.test.ClientBase.CountdownWatcher; | ||
| import org.junit.AfterClass; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| public class EpochWriteFailureTest extends QuorumPeerTestBase { | ||
| private static int SERVER_COUNT = 3; | ||
| private static int[] clientPorts = new int[SERVER_COUNT]; | ||
| private static MainThread[] mt = new MainThread[SERVER_COUNT]; | ||
| private static ZooKeeper zk; | ||
|
|
||
| /* | ||
| * Test case for https://issues.apache.org/jira/browse/ZOOKEEPER-2307 | ||
| * Expectation: During leader election when accepted epoch write to file | ||
| * fails, it should not complete leader election, also it should not update | ||
| * run time values of acceptedEpoch, | ||
| */ | ||
| @Test(timeout = 120000) | ||
| public void testAcceptedEpochWriteFailure() throws Exception { | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("admin.enableServer=false"); | ||
| sb.append("\n"); | ||
| String server; | ||
| for (int i = 0; i < SERVER_COUNT; i++) { | ||
| clientPorts[i] = PortAssignment.unique(); | ||
| server = "server." + i + "=127.0.0.1:" + PortAssignment.unique() + ":" | ||
| + PortAssignment.unique() + ":participant;127.0.0.1:" + clientPorts[i]; | ||
| sb.append(server); | ||
| sb.append("\n"); | ||
| } | ||
| String currentQuorumCfgSection = sb.toString(); | ||
| for (int i = 0; i < SERVER_COUNT - 1; i++) { | ||
| mt[i] = new MainThread(i, clientPorts[i], currentQuorumCfgSection, false); | ||
| mt[i].start(); | ||
| } | ||
|
|
||
| // ensure two servers started | ||
| for (int i = 0; i < SERVER_COUNT - 1; i++) { | ||
| Assert.assertTrue("waiting for server " + i + " being up", | ||
| ClientBase.waitForServerUp("127.0.0.1:" + clientPorts[i], CONNECTION_TIMEOUT)); | ||
| } | ||
|
|
||
| CountdownWatcher watch1 = new CountdownWatcher(); | ||
| zk = new ZooKeeper("127.0.0.1:" + clientPorts[0], ClientBase.CONNECTION_TIMEOUT, | ||
| watch1); | ||
| watch1.waitForConnected(ClientBase.CONNECTION_TIMEOUT); | ||
|
|
||
| String data = "originalData"; | ||
| zk.create("/epochIssue", data.getBytes(), Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT); | ||
|
|
||
| //initialize third server | ||
| mt[2] = new MainThread(2, clientPorts[2], currentQuorumCfgSection, false) { | ||
|
|
||
| @Override | ||
| public TestQPMain getTestQPMain() { | ||
| return new MockTestQPMain(); | ||
| } | ||
| }; | ||
|
|
||
| //This server has problem it fails while writing acceptedEpoch. | ||
| mt[2].start(); | ||
|
|
||
| /* | ||
| * Verify that problematic server does not start as acceptedEpoch update | ||
| * failure is injected and it keeps on trying to join the quorum | ||
| */ | ||
|
|
||
| Assert.assertFalse("verify server 2 not started", | ||
| ClientBase.waitForServerUp("127.0.0.1:" + clientPorts[2], CONNECTION_TIMEOUT / 2)); | ||
|
|
||
| QuorumPeer quorumPeer = mt[2].getQuorumPeer(); | ||
|
|
||
| Assert.assertEquals("acceptedEpoch must not have changed", 0, | ||
| quorumPeer.getAcceptedEpoch()); | ||
| Assert.assertEquals("currentEpoch must not have changed", 0, | ||
| quorumPeer.getCurrentEpoch()); | ||
| } | ||
|
|
||
| static class CustomQuorumPeer extends QuorumPeer { | ||
| CustomQuorumPeer(Map<Long, QuorumServer> quorumPeers, File snapDir, File logDir, int clientPort, | ||
| int electionAlg, long myid, int tickTime, int initLimit, int syncLimit, | ||
| int connectToLearnerMasterLimit) throws IOException { | ||
| super(quorumPeers, snapDir, logDir, clientPort, electionAlg, myid, tickTime, initLimit, syncLimit, connectToLearnerMasterLimit); | ||
| } | ||
|
|
||
| @Override | ||
| protected void writeLongToFile(String name, long value) throws IOException { | ||
| // initial epoch writing should be successful | ||
| if (0 != value) { | ||
| throw new IOException("Input/output error"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static class MockTestQPMain extends TestQPMain { | ||
| @Override | ||
| public void runFromConfig(QuorumPeerConfig config) | ||
| throws IOException { | ||
| quorumPeer = new CustomQuorumPeer(config.getQuorumVerifier().getAllMembers(), | ||
| config.getDataDir(), config.getDataLogDir(), | ||
| config.getClientPortAddress().getPort(), config.getElectionAlg(), | ||
| config.getServerId(), config.getTickTime(), config.getInitLimit(), | ||
| config.getSyncLimit(), config.getSyncLimit()); | ||
| quorumPeer.start(); | ||
| try { | ||
| quorumPeer.join(); | ||
| } catch (InterruptedException e) { | ||
| LOG.warn("Quorum Peer interrupted", e); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void tearDownAfterClass() throws InterruptedException { | ||
| for (int i = 0; i < SERVER_COUNT; i++) { | ||
| if (mt[i] != null) { | ||
| mt[i].shutdown(); | ||
| } | ||
| } | ||
| if (zk != null) { | ||
| zk.close(); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters