ZOOKEEPER-3388: Allow client port to support plaintext and encrypted connections simultaneously (3.5) #1174
Conversation
…connections simultaneously Author: Brian Nixon <nixon@fb.com> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Michael Han <hanm@apache.org> Closes apache#944 from enixon/client-port-uni
anmolnar
changed the title
There was a problem hiding this comment.
LGTM
(I also downloaded the patch and did a build locally with java 1.8 and executed the new unit test)
I added a minor comment about the documentation.
Also I think it would worth to backport https://issues.apache.org/jira/browse/ZOOKEEPER-3643 too (if/when it will be merged to master), as it enhances the documentation and the same testcase we backport in this PR.
|
|
||
| * *client.portUnification*: | ||
| (Java system properties: **zookeeper.client.portUnification**) | ||
| Specifies that the client port should accept SSL connections |
There was a problem hiding this comment.
please add the tag: **New in 3.5.7:**
There was a problem hiding this comment.
This is done. Thanks.
|
Refer to this link for build results (access rights to CI server needed): |
|
Based on the approvals in the master patch #944 , I'll commit this patch once the build is green. |
|
Refer to this link for build results (access rights to CI server needed): |
…connections simultaneously (3.5) Backport of #944 Author: Andor Molnar <andor@apache.org> Author: Brian Nixon <nixon@fb.com> Reviewers: andor@apache.org Closes #1174 from anmolnar/ZOOKEEPER-3388_35 and squashes the following commits: b51f843 [Andor Molnar] ZOOKEEPER-3388. Added new tag to documentation 744c938 [Brian Nixon] ZOOKEEPER-3388: Allow client port to support plaintext and encrypted connections simultaneously
|
Merged. Thanks. |
…d encrypted connections simultaneously (3.5) Backport of apache#944 Author: Andor Molnar <andor@apache.org> Author: Brian Nixon <nixon@fb.com> Reviewers: andor@apache.org Closes apache#1174 from anmolnar/ZOOKEEPER-3388_35 and squashes the following commits: b51f843 [Andor Molnar] ZOOKEEPER-3388. Added new tag to documentation 744c938 [Brian Nixon] ZOOKEEPER-3388: Allow client port to support plaintext and encrypted connections simultaneously (cherry picked from commit f21f951) Change-Id: I3481b36a065f036bc64f07cd82146935ec8bdd9f (cherry picked from commit 4c05e68)
Backport of #944