Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-3704: upgrade maven dependency-check to 5.3.0 #1231

Closed
wants to merge 1 commit into from

Conversation

phunt
Copy link
Contributor

@phunt phunt commented Jan 22, 2020

Upgrade to the latest version of maven dependency checker.

Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11

Upgrade to the latest version of maven dependency checker.

Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11
@phunt
Copy link
Contributor Author

phunt commented Jan 22, 2020

This should get applied to all applicable branches (3.5/3.6/master).

@eolivelli
Copy link
Contributor

It looks like ASF CI changed and we are no more able to compile the C client.


   [exec] make[1]: Leaving directory '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/target/c'
     [exec] Makefile:2106: recipe for target 'check-am' failed
     [exec] In file included from /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/tests/TestReconfigServer.cc:23:0:
     [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build-maven/zookeeper-client/zookeeper-client-c/include/zookeeper.h:36:10: fatal error: openssl/ossl_typ.h: No such file or directory
     [exec]  #include <openssl/ossl_typ.h>
     [exec]           ^~~~~~~~~~~~~~~~~~~~
     [exec] compilation terminated.
     [exec] make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
     [exec] make: *** [check-am] Error 2

@eolivelli
Copy link
Contributor

The error is not related to this patch, the patch is good to go

@asfgit asfgit closed this in 1fbaa26 Jan 23, 2020
asfgit pushed a commit that referenced this pull request Jan 23, 2020
Upgrade to the latest version of maven dependency checker.

Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11

Author: Patrick Hunt <phunt@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>

Closes #1231 from phunt/ZOOKEEPER-3704

(cherry picked from commit 1fbaa26)
Signed-off-by: Enrico Olivelli <enrico.olivelli@diennea.com>
asfgit pushed a commit that referenced this pull request Jan 23, 2020
Upgrade to the latest version of maven dependency checker.

Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11

Author: Patrick Hunt <phunt@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>

Closes #1231 from phunt/ZOOKEEPER-3704

(cherry picked from commit 1fbaa26)
Signed-off-by: Enrico Olivelli <enrico.olivelli@diennea.com>
@eolivelli
Copy link
Contributor

committed to 3.5,3.6 and 3.7

cc @nkalmar

junyoungKimGit pushed a commit to junyoungKimGit/zookeeper that referenced this pull request Feb 7, 2020
Upgrade to the latest version of maven dependency checker.

Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11

Author: Patrick Hunt <phunt@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>

Closes apache#1231 from phunt/ZOOKEEPER-3704
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
Upgrade to the latest version of maven dependency checker.

Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11

Author: Patrick Hunt <phunt@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>

Closes apache#1231 from phunt/ZOOKEEPER-3704
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
Upgrade to the latest version of maven dependency checker.

Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11

Author: Patrick Hunt <phunt@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>

Closes apache#1231 from phunt/ZOOKEEPER-3704
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
Upgrade to the latest version of maven dependency checker.

Change-Id: I5ac9c77bb02f54784ff3ed4bb668fe38fd88ee11

Author: Patrick Hunt <phunt@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>

Closes apache#1231 from phunt/ZOOKEEPER-3704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants