ZOOKEEPER-3701: Split brain on log disk full (3.5) #1237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue described here: https://issues.apache.org/jira/browse/ZOOKEEPER-3701 Proposing a fix with catching `IOException` within the truncate method to properly return with `false` if truncate fails. Author: Andor Molnar <andor@apache.org> Author: Andor Molnar <andor@cloudera.com> Reviewers: Ivan Kelly <ivank@apache.org>, Enrico Olivelli <eolivelli@apache.org>, Norbert Kalmar <nkalmar@apache.org> Closes apache#1233 from anmolnar/ZOOKEEPER-3701 (cherry picked from commit a4bc985) Signed-off-by: Norbert Kalmar <nkalmar@apache.org>
nkalmar
approved these changes
Jan 29, 2020
|
Soo... the build failed because releaseaudit just realised https://github.com/apache/zookeeper/blob/branch-3.5/zookeeper-server/src/test/java/org/apache/zookeeper/common/NetUtilsTest.java does not have an Apache header, which was committed in December?! Edit: I guess 3.5 has been failing since December. |
asfgit
pushed a commit
that referenced
this pull request
Jan 30, 2020
Backport of #1233 Unfortunately the unit test cannot be backported, because 3.5 doesn't have the abstract `requestSystemExit` feature. Author: Andor Molnar <andor@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org> Closes #1237 from anmolnar/ZOOKEEPER-3701_35
|
Merged to 3.5, thanks @anmolnar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1233
Unfortunately the unit test cannot be backported, because 3.5 doesn't have the abstract
requestSystemExitfeature.