-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner #1240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes #1240 from belugabehr/ZOOKEEPER-3708 (cherry picked from commit 68e1f7d) Signed-off-by: Andor Molnar <andor@apache.org>
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes #1240 from belugabehr/ZOOKEEPER-3708 (cherry picked from commit 68e1f7d) Signed-off-by: Andor Molnar <andor@apache.org>
Committed to 3.5, 3.6 and master branches. |
@anmolnar |
@eolivelli I wasn't sure about that either, but the patch does not do any harm and my thinking was that until we don't have a stable release on 3.6, we don't need to be super conservative with committing to 3.5. |
Otherwise you're probably right. We might want to lock down 3.5 and commit only security and bug fixes from now on. |
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
No description provided.