ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
pushed a commit
that referenced
this pull request
Feb 3, 2020
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes #1240 from belugabehr/ZOOKEEPER-3708 (cherry picked from commit 68e1f7d) Signed-off-by: Andor Molnar <andor@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Feb 3, 2020
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes #1240 from belugabehr/ZOOKEEPER-3708 (cherry picked from commit 68e1f7d) Signed-off-by: Andor Molnar <andor@apache.org>
|
Committed to 3.5, 3.6 and master branches. |
|
@anmolnar |
|
@eolivelli I wasn't sure about that either, but the patch does not do any harm and my thinking was that until we don't have a stable release on 3.6, we don't need to be super conservative with committing to 3.5. |
|
Otherwise you're probably right. We might want to lock down 3.5 and commit only security and bug fixes from now on. |
junyoungKimGit
pushed a commit
to junyoungKimGit/zookeeper
that referenced
this pull request
Feb 7, 2020
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
stickyhipp
pushed a commit
to stickyhipp/zookeeper
that referenced
this pull request
Aug 19, 2020
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.