ZOOKEEPER-3865: fix backward-compatibility for ZooKeeperServer constructor #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symat
changed the title
|
merging as soon as CI is green. |
|
thanks for the quick review! please merge this only to master and branch-3.6 for branch-3.5 I created #1383 |
|
retest maven build |
|
@eolivelli do you have time to merge this? (and #1383) |
eolivelli
pushed a commit
that referenced
this pull request
Jun 19, 2020
…uctor In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well). In this PR I restore the original constructor for master and branch-3.6. For branch-3.5 I will submit an other PR, that will make it compatible with e.g. Curator 4.3. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes #1382 from symat/ZOOKEEPER-3865 (cherry picked from commit f6c9bac) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
|
done, |
|
thanks! :) |
stickyhipp
pushed a commit
to stickyhipp/zookeeper
that referenced
this pull request
Aug 19, 2020
…uctor In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well). In this PR I restore the original constructor for master and branch-3.6. For branch-3.5 I will submit an other PR, that will make it compatible with e.g. Curator 4.3. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1382 from symat/ZOOKEEPER-3865
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…uctor In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well). In this PR I restore the original constructor for master and branch-3.6. For branch-3.5 I will submit an other PR, that will make it compatible with e.g. Curator 4.3. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1382 from symat/ZOOKEEPER-3865
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…uctor In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well). In this PR I restore the original constructor for master and branch-3.6. For branch-3.5 I will submit an other PR, that will make it compatible with e.g. Curator 4.3. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1382 from symat/ZOOKEEPER-3865
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…uctor In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well). In this PR I restore the original constructor for master and branch-3.6. For branch-3.5 I will submit an other PR, that will make it compatible with e.g. Curator 4.3. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1382 from symat/ZOOKEEPER-3865
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
…uctor In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well). In this PR I restore the original constructor for master and branch-3.6. For branch-3.5 I will submit an other PR, that will make it compatible with e.g. Curator 4.3. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1382 from symat/ZOOKEEPER-3865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well).
In this PR I restore the original constructor for master and branch-3.6.
For branch-3.5 I will submit an other PR, that will make it compatible with e.g. Curator 4.3.