ZOOKEEPER-3865: fix backward-compatibility for ZooKeeperServer constructor #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest ant build |
|
I see the ant job fails again around the C client build, without an obvious error message. I've seen this before... Anyway, it shouldn't be related to the PR I think. |
|
retest maven build |
|
retest ant build |
|
@eolivelli do you think we can merge this? Only the ant job failed with some unrelated problems (and also the change is pretty harmless). I'm happy to merge if you agree but don't have the time. |
|
I can merge it tomorrow |
|
merging |
eolivelli
pushed a commit
that referenced
this pull request
Jun 23, 2020
…uctor In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well). In this PR I restore the original constructor for branch-3.5 making it compatible with e.g. Curator 4.3. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes #1383 from symat/ZOOKEEPER-3865-branch-3.5
|
pushed to branch-3.5 |
|
thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the fix of ZOOKEEPER-3829 I accidentally changed a public constructor of ZooKeeper server. I didn’t realize Curator is using it for testing (and maybe other Apache projects are doing so as well).
In this PR I restore the original constructor for branch-3.5 making it compatible with e.g. Curator 4.3.