ZOOKEEPER-2266: Integrate JaCoCo Coverage Library

[nkalmar]

No description provided.

[nkalmar]

We've seen demand for code coverage, and some apache projects are already using jacoco.
I found an old jira to integrate jacoco with ant.

I know this doesn't really tell us how good are testing is (specially that for many tests we spin up a whole zk server), but there is a demand to see this in reports, so.. here it is.

I did several tests (all test, one test, jacoco on/off and see generated sources - should be only in zk-server), a good starting point:
'mvn clean install -Dtest=WatcherTest -DfailIfNoTests=false -Dcodecoverage'

By default code coverage is off, enable it by adding -Dcodecoverage to mvn args.

[eolivelli]

I have some experience with JaCoCo.
For an OpenSource project like Zookeeper we should integrate it with services like CodeCov or Coveralls.io (I am using Coveralls for instance)

Such tool will be useful for requiring a quality gate on pull requests and in order to increase code coverage in general.

[nkalmar]

Hi @eolivelli , I tried to integrate coveralls according to the readme.

I enabled Apache/ZooKeeper on github in coveralls.io.
Now, if I understand this, I should just add
after_success:

• mvn clean cobertura:cobertura coveralls:report

to travis.yml? Is that it? (I already added the maven plugin dependency, it doesn't run in local as it needs the repokey)

[eolivelli]

@nkalmar Travis is not running tests, so it will be useless.
We have to add it to Jenkins builds.
It will also require to share the secret TOKEN on Jenkins, because in Travis is it simpler because there is an automatic integration .

Unfortunately the test suite it too big for Travis (or at least we have too many output pauses)
if we fix the Travis build, by running at least Java tests, we can go the way you are suggesting

cc @anmolnar

[hanm]

we already have clover for code coverage (in ant days) and seems maven build support clover too. do we plan to deprecate clover in favor of JaCoCo?

in any case, it's good to have more testing related addition for ZK as part of CI pipeline.