Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3971: Auto close resources with try catch block #1507

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3971: Auto close resources with try catch block #1507

wants to merge 1 commit into from

Conversation

kamaci
Copy link
Member

@kamaci kamaci commented Oct 15, 2020

No description provided.

@kamaci kamaci mentioned this pull request Oct 15, 2020
Closed
ctubbsii
ctubbsii approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this supersedes #1506 and looks okay to me.

By the way, I don't think you necessarily needed to close the old PR and make a new one. You can update the PR by pushing (or force-pushing) to the branch to update the commit log, and you can manually edit the PR ticket title in the web UI.

@kamaci
Copy link
Member Author

kamaci commented Oct 15, 2020

It looks like this supersedes #1506 and looks okay to me.

By the way, I don't think you necessarily needed to close the old PR and make a new one. You can update the PR by pushing (or force-pushing) to the branch to update the commit log, and you can manually edit the PR ticket title in the web UI.

I've renamed the branch too.

@ctubbsii
Copy link
Member

It looks like this supersedes #1506 and looks okay to me.
By the way, I don't think you necessarily needed to close the old PR and make a new one. You can update the PR by pushing (or force-pushing) to the branch to update the commit log, and you can manually edit the PR ticket title in the web UI.

I've renamed the branch too.

Ah, yes, if you rename the branch, you have to create a new PR. However, the branch name doesn't matter. That's on the contributor end, not on the receiving end. I'm not sure why the contributing guide recommends using a branch name based on the JIRA number... it doesn't matter... you can name it whatever you want.

@kamaci
Copy link
Member Author

kamaci commented Oct 17, 2020

Is there anything left to do for this PR?

@eolivelli
Copy link
Contributor

@kamaci everything is perfect.
I am just waiting for another "committer" to approve this patch and then I will be happy to merge it.
This is our rule, at least two "binding" votes for every code patch.

thank you very much!

thank you @ctubbsii for reviewing the patch as well

@asfgit asfgit closed this in f06db8c Oct 21, 2020
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@kamaci @RokLenarcic
ZOOKEEPER-3971: Auto close resources with try catch block
13ff367 
Author: kamaci <furkankamaci@gmail.com>

Reviewers: Michael Han <hanm@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Christopher Tubbs

Closes apache#1507 from kamaci/ZOOKEEPER-3971
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@kamaci @RokLenarcic
ZOOKEEPER-3971: Auto close resources with try catch block
5cf6b99 
Author: kamaci <furkankamaci@gmail.com>

Reviewers: Michael Han <hanm@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Christopher Tubbs

Closes apache#1507 from kamaci/ZOOKEEPER-3971
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@kamaci @RokLenarcic
ZOOKEEPER-3971: Auto close resources with try catch block
4e21f77 
Author: kamaci <furkankamaci@gmail.com>

Reviewers: Michael Han <hanm@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Christopher Tubbs

Closes apache#1507 from kamaci/ZOOKEEPER-3971
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@kamaci @RokLenarcic
ZOOKEEPER-3971: Auto close resources with try catch block
3ee8f04 
Author: kamaci <furkankamaci@gmail.com>

Reviewers: Michael Han <hanm@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Christopher Tubbs

Closes apache#1507 from kamaci/ZOOKEEPER-3971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanm hanm hanm approved these changes

@ctubbsii ctubbsii ctubbsii approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamaci @ctubbsii @eolivelli @hanm