ZOOKEEPER-2719: Pull changes for TTL Nodes into 3.5 branch #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk needed to support TTLs is there already. In order not to break on-disk and protocol compatibility the ephemeralOwner is yet-again overloaded to have special meaning. New opcodes and transaction records had to be added in a similar manner to Containers NOTE: This patch was originally in Review Board and was moved to Github for ease/convenience. RB link: https://reviews.apache.org/r/46983/#comment214810
|
LGTM. I did some testing using CLI and it works as expected. |
asfgit
pushed a commit
that referenced
this pull request
Mar 17, 2017
This PR cherry-picks changes for TTL nodes (ZOOKEEPER-2169) and the CLI for it (ZOOKEEPER-2608) into branch-3.5. Author: randgalt <jordan@jordanzimmerman.com> Reviewers: Michael Han <hanm@apache.org>, Camille Fournier <camille@apache.org> Closes #192 from Randgalt/ZOOKEEPER-2719 and squashes the following commits: 6343001 [randgalt] Added ttl option to CLI create command 39b969b [randgalt] Removed bogus import 64f77a5 [randgalt] cleaned up some doc merge issues 66fdccb [randgalt] This patch takes advantage of 3.5's container support. Most of the work needed to support TTLs is there already. In order not to break on-disk and protocol compatibility the ephemeralOwner is yet-again overloaded to have special meaning. New opcodes and transaction records had to be added in a similar manner to Containers
|
Hi @Randgalt, congrats on getting this PR ported to 3.5! 😃 Please, could you close this PR as it has been merged? Best regards! |
|
merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes for TTL nodes (ZOOKEEPER-2169) and the CLI for it (ZOOKEEPER-2608) into branch-3.5.