Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4732: upgrade plugins, fix Reproducible Builds issues #2042

Merged
merged 1 commit into from Aug 4, 2023

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Aug 4, 2023

see https://issues.apache.org/jira/browse/ZOOKEEPER-4732

this PR contains only the few plugins upgrades: that will fix 3 issues on 7

I did not try change the timestamp in generated code as a small discussion is required first = remove the timestamp, switch from current timestamp to Git commit timestamp? or any other idea?

i did not investigate the last issue on pom.properties order in zookeeper-it either, I suppose it's just about sorting when dumping, without any user-visible impact...

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 4, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit 15f29b5 into apache:master Aug 4, 2023
14 checks passed
@eolivelli
Copy link
Contributor

This patch is trivial, so I am committing it directly to master branch and to branch-3.9

eolivelli pushed a commit that referenced this pull request Aug 4, 2023
@eolivelli
Copy link
Contributor

cherry-picked to branch-3.9, this way we can leverage it on 3.9.1

@eolivelli
Copy link
Contributor

Thank you very much @hboutemy

@hboutemy hboutemy deleted the ZOOKEEPER-4732 branch August 14, 2023 20:18
rahulrane50 pushed a commit to rahulrane50/zookeeper that referenced this pull request Sep 15, 2023
asfgit pushed a commit that referenced this pull request Oct 2, 2023
asfgit pushed a commit that referenced this pull request Oct 3, 2023
AlphaCanisMajoris pushed a commit to AlphaCanisMajoris/zookeeper that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants