ZOOKEEPER-2630: Use interface type instead of implementation type whe… #354
Conversation
…n appropriate. Checked and fixed Set, Map and List interface usages.
There was a problem hiding this comment.
So I checked this using the jar compatibility script added in ZOOKEEPER-2864 and everything looks great. I was just wondering if you used a tool to make all these changes or did so manually.
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.Iterator; | ||
| import java.util.*; |
There was a problem hiding this comment.
we generally avoid using * inputs
There was a problem hiding this comment.
working on the fix in my next commit
…n appropriate. remove import java.unit.*;
|
fixed the issues with the imports |
|
Committed to master: 1165794. |
|
@tamaashu This patch does not apply to branch-3.4 and branch-3.5. For now it's only applied on master and I resolved the JIRA with a target version of 3.6. If you'd like this land on 3.4 and 3.5, please create separate pull requests. |
|
Late to the party but awesome work! Congrats! 👍 @hanm are those changes applied to both master and branch-3.5? No branch-4.5 backport, right? |
|
@eribeiro not sure why you asked - thought I made it clear that the patch for now only applied on master, because this pull request can't apply as is on other branches without some additional work which I don't have time to do myself. That said, if you or anyone else want same change land on other branches, please feel free to propose pull requests. |
|
@hanm oh, totally my fault asking an already answered question. Excuse me. Even tough, I see my (useless) question and your comment were roughly 9 hours ago, and I remember very well the last comment I saw on this thread being "Committed to master: 1165794." (also about 9 hours ago). So, I suppose it was some sort of eventual consistency glitch that prevented me from reading your comment before posting. Whatever, sorry about that. @tamaashu Please, let me know if you are planning to work on porting the changes in this PR to branch-3.5 and branch-3.4. If you cannot and don't mind, I can pick up the work of porting the changes in this PR to branch-3.5, at least. Best regards! |
Use interface type instead of implementation type when appropriate. There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice. Checked and fixed Set, Map and List interface usages. Author: Tamas Penzes <tamaas@cloudera.com> Reviewers: Abe Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#354 from tamaashu/ZOOKEEPER-2630 (cherry picked from commit 1165794)
Use interface type instead of implementation type when appropriate. There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice. Checked and fixed Set, Map and List interface usages. Author: Tamas Penzes <tamaas@cloudera.com> Reviewers: Abe Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#354 from tamaashu/ZOOKEEPER-2630 (cherry picked from commit 1165794)
Use interface type instead of implementation type when appropriate. There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice. Checked and fixed Set, Map and List interface usages. Author: Tamas Penzes <tamaas@cloudera.com> Reviewers: Abe Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#354 from tamaashu/ZOOKEEPER-2630
Use interface type instead of implementation type when appropriate. There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice. Checked and fixed Set, Map and List interface usages. Author: Tamas Penzes <tamaas@cloudera.com> Reviewers: Abe Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#354 from tamaashu/ZOOKEEPER-2630
Use interface type instead of implementation type when appropriate.
There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice.
Checked and fixed Set, Map and List interface usages.