ZOOKEEPER-2630: Use interface type instead of implementation type whe… #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use interface type instead of implementation type when appropriate. There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice. Checked and fixed Set, Map and List interface usages. Author: Tamas Penzes <tamaas@cloudera.com> Reviewers: Abe Fine <afine@apache.org>, Michael Han <hanm@apache.org> Closes apache#354 from tamaashu/ZOOKEEPER-2630 (cherry picked from commit 1165794)
missing import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use interface type instead of implementation type when appropriate.
There are a couple of places in code base where we declare a field / variable as implementation type (i.e. HashMap, HashSet) instead of interface type (i.e. Map, Set), while in other places we do the opposite by declaring as interface type. A quick check indicates that most if not all of these places could be updated so we have a consistent style over the code base (prefer using interface type), which is also a good coding style to stick per best practice.
Checked and fixed Set, Map and List interface usages.
Author: Tamas Penzes tamaas@cloudera.com
Reviewers: Abe Fine afine@apache.org, Michael Han hanm@apache.org
Closes #354 from tamaashu/ZOOKEEPER-2630
(cherry picked from commit 1165794)