ZOOKEEPER-2961: Fix testElectionFraud Flakyness #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @afine |
|
Hi @anmolnar - I had a description in the JIRA that I just copied here. I hope it clears things up. |
asfgit
pushed a commit
that referenced
this pull request
Jan 18, 2018
This test relies on hooking into our logging system and creates a new appender using a PatternLayout object shared with the CONSOLE appender. PatternLayout has some synchronization issues (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html) so we should create a new instance of it. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes #437 from afine/ZOOKEEPER-2961_master Change-Id: I1c81d37b94b12e0721a671deb2fc983773f88fd9 (cherry picked from commit 77d6b76) Signed-off-by: Patrick Hunt <phunt@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jan 19, 2018
This test relies on hooking into our logging system and creates a new appender using a PatternLayout object shared with the CONSOLE appender. PatternLayout has some synchronization issues (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html) so we should create a new instance of it. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes #437 from afine/ZOOKEEPER-2961_master Change-Id: I1c81d37b94b12e0721a671deb2fc983773f88fd9 (cherry picked from commit 77d6b76) Signed-off-by: Patrick Hunt <phunt@apache.org>
|
LGTM +1. Thanks @afine |
maoling
pushed a commit
to maoling/zookeeper
that referenced
this pull request
Jan 26, 2018
This test relies on hooking into our logging system and creates a new appender using a PatternLayout object shared with the CONSOLE appender. PatternLayout has some synchronization issues (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html) so we should create a new instance of it. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes apache#437 from afine/ZOOKEEPER-2961_master Change-Id: I1c81d37b94b12e0721a671deb2fc983773f88fd9
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
This test relies on hooking into our logging system and creates a new appender using a PatternLayout object shared with the CONSOLE appender. PatternLayout has some synchronization issues (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html) so we should create a new instance of it. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes apache#437 from afine/ZOOKEEPER-2961_master Change-Id: I1c81d37b94b12e0721a671deb2fc983773f88fd9
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
This test relies on hooking into our logging system and creates a new appender using a PatternLayout object shared with the CONSOLE appender. PatternLayout has some synchronization issues (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html) so we should create a new instance of it. Author: Abraham Fine <afine@apache.org> Reviewers: phunt@apache.org Closes apache#437 from afine/ZOOKEEPER-2961_master Change-Id: I1c81d37b94b12e0721a671deb2fc983773f88fd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test relies on hooking into our logging system and creates a new appender using a PatternLayout object shared with the CONSOLE appender. PatternLayout has some synchronization issues (https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html) so we should create a new instance of it.