ZOOKEEPER-2988: NPE triggered if server receives a vote for a server … #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2018 12:23
…id not in their voting view
…d generify some components
|
The only failure report out of Jenkins is "Test org.apache.zookeeper.test.FollowerResyncConcurrencyTest FAILED (crashed)". I'm unable to repro any issue with that test on my branch locally, is there a good way to re-run the test? |
asfgit
pushed a commit
that referenced
this pull request
May 2, 2018
…id not in their voting view Author: Brian Nixon <nixon@fb.com> Reviewers: Michael Han <hanm@apache.org> Closes #478 from enixon/ZOOKEEPER-2988-3.4
|
@enixon "FollowerResyncConcurrencyTest " is a known flaky test (and the error in this case is infrastructure issues - the JVM abnormally exit). I tested your patch using a Jenkins job and everything looks good. Committed, please close this pull request.
P.S. to kick off the pre-commit build bot, you can close the pull request and reopen it. |
|
Thanks, @hanm ! |
nkalmar
pushed a commit
to nkalmar/zookeeper
that referenced
this pull request
May 11, 2018
…id not in their voting view Author: Brian Nixon <nixon@fb.com> Reviewers: Michael Han <hanm@apache.org> Closes apache#478 from enixon/ZOOKEEPER-2988-3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…id not in their voting view