ZOOKEEPER-3025: Make hashtable search include
#505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ZOOKEEPER-2999 removed the directory side-effect of `include_directories(include)`, and added it as a target-level include to the `zookeeper` library, this broke the Windows build. It worked on Linux (where the patch was tested) because `winconfig.h` and is not included, but on Windows, the `hashtable` library included `winconfig.h` (found in `include`) but no longer knew where to find it. The fix is to add `include` to the `hashtable` library's list of include directories.
|
Built successfully both in-tree and out-of-tree on Windows using the VS generator, also successfully built with the Ninja generator 😉 |
asfgit
pushed a commit
that referenced
this pull request
Apr 24, 2018
…clude` When ZOOKEEPER-2999 removed the directory side-effect of `include_directories(include)`, and added it as a target-level include to the `zookeeper` library, this broke the Windows build. It worked on Linux (where the patch was tested) because `winconfig.h` and is not included, but on Windows, the `hashtable` library included `winconfig.h` (found in `include`) but no longer knew where to find it. The fix is to add `include` to the `hashtable` library's list of include directories. Author: Andrew Schwartzmeyer <andrew@schwartzmeyer.com> Reviewers: phunt@apache.org Closes #505 from andschwa/ZOOKEEPER-3025 Change-Id: I657f8e234082068fb7adf56dad2d68cbb4bc1d31 (cherry picked from commit cb6cae9) Signed-off-by: Patrick Hunt <phunt@apache.org>
|
+1. Thanks @andschwa |
nkalmar
pushed a commit
to nkalmar/zookeeper
that referenced
this pull request
Apr 24, 2018
…clude` When ZOOKEEPER-2999 removed the directory side-effect of `include_directories(include)`, and added it as a target-level include to the `zookeeper` library, this broke the Windows build. It worked on Linux (where the patch was tested) because `winconfig.h` and is not included, but on Windows, the `hashtable` library included `winconfig.h` (found in `include`) but no longer knew where to find it. The fix is to add `include` to the `hashtable` library's list of include directories. Author: Andrew Schwartzmeyer <andrew@schwartzmeyer.com> Reviewers: phunt@apache.org Closes apache#505 from andschwa/ZOOKEEPER-3025 Change-Id: I657f8e234082068fb7adf56dad2d68cbb4bc1d31
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
…clude` When ZOOKEEPER-2999 removed the directory side-effect of `include_directories(include)`, and added it as a target-level include to the `zookeeper` library, this broke the Windows build. It worked on Linux (where the patch was tested) because `winconfig.h` and is not included, but on Windows, the `hashtable` library included `winconfig.h` (found in `include`) but no longer knew where to find it. The fix is to add `include` to the `hashtable` library's list of include directories. Author: Andrew Schwartzmeyer <andrew@schwartzmeyer.com> Reviewers: phunt@apache.org Closes apache#505 from andschwa/ZOOKEEPER-3025 Change-Id: I657f8e234082068fb7adf56dad2d68cbb4bc1d31
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
…clude` When ZOOKEEPER-2999 removed the directory side-effect of `include_directories(include)`, and added it as a target-level include to the `zookeeper` library, this broke the Windows build. It worked on Linux (where the patch was tested) because `winconfig.h` and is not included, but on Windows, the `hashtable` library included `winconfig.h` (found in `include`) but no longer knew where to find it. The fix is to add `include` to the `hashtable` library's list of include directories. Author: Andrew Schwartzmeyer <andrew@schwartzmeyer.com> Reviewers: phunt@apache.org Closes apache#505 from andschwa/ZOOKEEPER-3025 Change-Id: I657f8e234082068fb7adf56dad2d68cbb4bc1d31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ZOOKEEPER-2999 removed the directory side-effect of
include_directories(include), and added it as a target-level includeto the
zookeeperlibrary, this broke the Windows build. It worked onLinux (where the patch was tested) because
winconfig.hand is notincluded, but on Windows, the
hashtablelibrary includedwinconfig.h(found ininclude) but no longer knew where to findit. The fix is to add
includeto thehashtablelibrary's list ofinclude directories.