-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky #521
ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky #521
Conversation
lavacat
commented
May 14, 2018
- relaxed check of outstanding proposals queue
- close clients after restart
- restart client after old leader restart
19c44eb
to
c8646e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 lgtm, just a small suggestion
// there can be extra sessionClose proposals | ||
Assert.assertTrue(outstanding.size() > 0); | ||
Proposal p = findProposalOfType(outstanding, OpCode.create); | ||
Assert.assertNotNull(p); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some message to the assert here to explain what could have gone wrong.
c8646e6
to
44dd195
Compare
- relaxed check of outstanding proposals queue - close clients after restart - restart client after old leader restart
9a5e1df
to
d1f9d44
Compare
Motivation: - LETest is flaky - LeaderElection is already deprecated and removed in trunk
d1f9d44
to
c361efa
Compare
@anmolnar thanks, updated |
@anmolnar Are there any concerns about this PR? I can remove "ignore LETest" commit. It was failing for me multiple times on PR test runs, but it's not on Flaky Dashboard. testFailedTxnAsPartOfQuorumLoss is still listed as flaky on Dashboard, and I think this will fix it |
@lavacat I think you're good to go as it is now. I've just become a committer recently, once I learn how to use the commit script, I'm happy to merge this. ;) |
ping @anmolnar |
@anmolnar yes, only 3.5 |
- relaxed check of outstanding proposals queue - close clients after restart - restart client after old leader restart Author: Bogdan Kanivets <bkanivets@gmail.com> Reviewers: Andor Molnar <andor@apache.org> Closes #521 from lavacat/testFailedTxnAsPartOfQuorumLoss-fix and squashes the following commits: c361efa [Bogdan Kanivets] ZOOKEEPER-1932: ignore LETest 427ab8c [Bogdan Kanivets] ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss is flaky
Committed to 3.5 branch. Thanks @lavacat |
@lavacat I second that. It would be great to fix this on all branches. |