Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3122 - fix files included in tarballs #897

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3122 - fix files included in tarballs #897

wants to merge 1 commit into from

Conversation

nkalmar
Copy link
Contributor

@nkalmar nkalmar commented Apr 8, 2019

No description provided.

eolivelli
eolivelli approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
I will be happy to check the RC artifacts before the vote if you want @anmolnar

anmolnar
anmolnar approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Great stuff!

@nkalmar
Copy link
Contributor Author

nkalmar commented Apr 8, 2019

retest maven build

@nkalmar nkalmar closed this Apr 8, 2019
@nkalmar nkalmar reopened this Apr 8, 2019
@nkalmar nkalmar closed this Apr 8, 2019
@nkalmar nkalmar reopened this Apr 8, 2019
@asfgit asfgit closed this in 1e8286f Apr 9, 2019
asfgit pushed a commit that referenced this pull request Apr 9, 2019
@nkalmar @anmolnar
ZOOKEEPER-3122: fix files included in tarballs
b1f2804 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes #897 from nkalmar/ZK-3122

(cherry picked from commit 1e8286f)
Signed-off-by: Andor Molnar <andor@apache.org>
@anmolnar
Copy link
Contributor

anmolnar commented Apr 9, 2019

Committed to master and 3.5 branches. Thanks @nkalmar !

asfgit pushed a commit that referenced this pull request Apr 9, 2019
@nkalmar @anmolnar
ZOOKEEPER-3122: fix files included in tarballs
d1a5390 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes #897 from nkalmar/ZK-3122

(cherry picked from commit 1e8286f)
Signed-off-by: Andor Molnar <andor@apache.org>
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@nkalmar @RokLenarcic
ZOOKEEPER-3122: fix files included in tarballs
52f5267 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes apache#897 from nkalmar/ZK-3122
@nkalmar nkalmar deleted the ZK-3122 branch October 6, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnar anmolnar anmolnar approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkalmar @anmolnar @eolivelli