Add command line history tests #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #16. |
|
I'm not entirely sure why this would be failing right now on Linux but it seems like there is some sort of problem loading lines from a file. Nothing seems out of the ordinary here code wise so I'll have to do a bit more digging to figure it out. Interestingly enough, there are no problems on macOS. |
Essentially what I've done here is pull a patch from Github user @emvigo related to building linenoise using C11 without errors on Linux. The hope is that this might fix the history test errors I'm seeing on CI right now. - antirez/linenoise#173 - https://github.com/emvigo
|
I was able to pull in this PR from a few years ago and that fixed all of the problems. I think the problem was that it was missing the string headers and that caused problems with Thanks @emvigo for that PR from 5 years ago! It was a big help. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that this was something that could be tested in a relatively straightforward manner without needing an interactive console session.