Fixed warnings when using -Wall -Wextra -Wpedantic -std=c11 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apainintheneck
added a commit
to apainintheneck/crystal-linenoise
that referenced
this pull request
Feb 4, 2024
Essentially what I've done here is pull a patch from Github user @emvigo related to building linenoise using C11 without errors on Linux. The hope is that this might fix the history test errors I'm seeing on CI right now. - antirez/linenoise#173 - https://github.com/emvigo
This was referenced Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Using this patch, the source and the example become fully compliant under -std=c11, yielding zero warnings when using -Wall -Wextra -Wpedantic, which is a requirement for a project I'm working on I may use linenoise for.
Looking forward to your review!
Eugenio