Update flake and improve nix setup for development #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2855 +/- ##
==========================================
+ Coverage 78.88% 78.89% +0.01%
==========================================
Files 467 467
Lines 15956 15956
Branches 2625 2625
==========================================
+ Hits 12587 12589 +2
+ Misses 3369 3367 -2 ☔ View full report in Codecov by Sentry. |
shonfeder
approved these changes
Mar 7, 2024
CONTRIBUTING.md
Outdated
Comment on lines
208
to
213
| If you want to use direnv to setup your environment with nix (instead of using a | ||
| shell), you will need to add `use flake;` to your `.envrc`, and then running | ||
| `direnv allow`: | ||
|
|
||
| ```sh | ||
| echo "use flake;" >> .envrc && direnv allow |
There was a problem hiding this comment.
I think the .local-envrc could be used for this without requiring dirtying the worktree?
There was a problem hiding this comment.
Ah right, that should be better! Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This PR:
flake.nixto remove sourcing of.envrcfile which resulted in a circular dependency ifdirenvwas used to load nix. Other changes inflake.nixare just auto-formatting.CONTRIBUTING.mdwith how to use nix withdirenv.flake.lock(withnix flake update) so the pinned version ofmetalsis compatible with the scala version declared inbuild.sbt.