Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requirements-test.txt #182

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Update requirements-test.txt #182

merged 1 commit into from
Dec 10, 2018

Conversation

tofu-rocketry
Copy link
Member

Restrict coveralls to version that supports Python 2.6

@tofu-rocketry
Update requirements-test.txt
c0996c1 
Restrict coveralls to version that supports Python 2.6
@tofu-rocketry tofu-rocketry added this to the 1.8.0 milestone Dec 7, 2018
@tofu-rocketry tofu-rocketry self-assigned this Dec 7, 2018
jrha
jrha approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but how did this decrease coverage?

@tofu-rocketry
Copy link
Member Author

Probably because the coverage results actually uploaded properly at last. I think there may be minor coverage differences between Python 2.6 and 2.7.

@tofu-rocketry tofu-rocketry merged commit 4f42aaa into apel:dev Dec 10, 2018
@tofu-rocketry tofu-rocketry deleted the coveralls-ver branch December 10, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrha jrha jrha approved these changes

@gregcorbett gregcorbett Awaiting requested review from gregcorbett

Assignees

@tofu-rocketry tofu-rocketry

Labels
enhancement
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tofu-rocketry @jrha