Release 1.9.1 to master #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.9.0 to dev
These is the sql_mode used in production. The schmeas don't work with the later 10.2.x defaults currently.
Versions of MySQL that aren't ancient don't allow null in primary keys, so this changes the default for LrmsId from NULL to empty string.
Travis, MySQL and testing fixes
timeit is more designed for performance measurement of small pieces of code whereas we have a long running process and we are more interested in the wall clock time of the process.
Adds timer to summariser log
Not every build system will have access to fedora-packager, but only a subset of what's included with that is actually required.
Add RPM build workflow for tags
Add pre-commit config and tidy up
* Cap mock below 4.0.0 - version 4 dropped support for Python 2.7 Co-authored-by: Adrian Coveney <tofu-rocketry@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2.2.4 to 3.1.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2.2.4...v3.1.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
- 3.4.0 dropped support for Python 2 - https://github.com/python-ldap/python-ldap/releases/tag/python-ldap-3.4.0
- As commas are allowed in an IGTF DN, just not in the `DC` part. - The subsequent check that the DN begins with a slash should be sufficient to ensure DNs aren't in the comma separated format.
- we probably don't want to accept DNs like that, even if they are technically valid DNs. More often than not it's an error getting the DN from OpenSSL.
Remove check that there are no commas in the DN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.