-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow branch-specific build scripts #6
Conversation
This simplifies the configuration because it means that you can edit a simple text file, instead of a shell script. It lets users build a subset of branches instead of building all of them.
On Wed, May 25, 2011 at 9:03 AM, alandekok
Why not just have your build.sh run both? ./configure --enable-foo Similarly, I doubt you actually want to build differently on different I'd suggest just having your build.sh do two different things based on Have fun, Avery |
I'd rather not do 2 builds from one script because one might succeed and the other fail. It would be "cleaner" to separate the output and success/fail status. Using branch-specific scripts is nice because they don't conflict with upstream changes. The gitbuilder repo can be updated, and the build.sh script changed completely. But that won't affect any local changes, and there won't be any conflicts to merge. |
On Thu, May 26, 2011 at 3:24 AM, alandekok
Yeah, but that's a generalization of the "I want to have multiple It would be nice to solve that problem in a more general way, I agree,
Oh, I definitely wouldn't suggest putting the build scripts into the The important thing is to have the build script depend on the Have fun, Avery |
Much time has passed, but I still think per-branch scripts is not the right approach. A given commit might be on multiple branches. In the intervening years, one option has come up though: like Github actions does it, put your build scripts right inside the repo, and they can do whatever they want. |
It's sometimes useful to have different build scripts for different branches.
The "build.sh" script is used by default. However, if a "build-$BRANCH.sh" script is defined,
that script is used instead.
We use this locally to build with different compliation flags, or for cross-compiling.
It would be useful to extend gitbuilder to have multiple builds for one branch:
./configure --enable-foo
versus
./configure --disable-foo
It's not clear to me how this can be done with the current framework. The pass/fail status is per commit, not per "variant of commit"