minimal/do: allow for relative shebangs #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of do expects #! to be followed by a /. A variety of tested systems treat the first word which follows #! as a path (which could be absolute or relative). Additionally, #! can be followed by spaces before the first path character. This patch addresses this potential incompatibility as a side effect. An example usecase of relative paths in shebang in a redo based build system can be seen here: https://git.sr.ht/~tk/pack/commit/01438f00d44adf33f59da729b347eca60cb461a8 This patch was tested to work in a variety of situations and systems.
|
I would advise to just test whether the executable bit is set, and leave shebang parsing to the OS, calling the script with /bin/sh otherwise. There is a good reason, why Unix avoids executing arbitrary files and I've always found it strange that this redo implementation operates around the executable bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of do expects #! to be followed by a /. A variety of
tested systems treat the first word which follows #! as a path (which
could be absolute or relative). Additionally, #! can be followed by
spaces before the first path character. This patch addresses this
potential incompatibility as a side effect.
An example usecase of relative paths in shebang in a redo based build
system can be seen here:
https://git.sr.ht/~tk/pack/commit/01438f00d44adf33f59da729b347eca60cb461a8
This patch was tested to work in a variety of situations and systems.
Possibly mandatory legalese: I disclaim any copyright to this patch thereby placing it in the public domain, in line with the public domain status of minimal/do.