Fix javadocs issues with missing tags

apereo · Dec 2, 2016 · ed82928 · ed82928
1 parent 8ac105e
commit ed82928
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/...va/org/apereo/cas/configuration/model/core/web/security/AdminPagesSecurityProperties.java b/...va/org/apereo/cas/configuration/model/core/web/security/AdminPagesSecurityProperties.java
@@ -1,18 +1,20 @@
 package org.apereo.cas.configuration.model.core.web.security;
 
+import com.google.common.collect.Sets;
 import org.springframework.core.io.Resource;
 
+import java.util.Set;
+
 /**
  * This is {@link AdminPagesSecurityProperties}.
  *
  * @author Misagh Moayyed
  * @since 5.0.0
  */
-
 public class AdminPagesSecurityProperties {
 
     private String ip = "127\\.0\\.0\\.1|0:0:0:0:0:0:0:1";
-    private String adminRoles = "ROLE_ADMIN";
+    private Set<String> adminRoles = Sets.newHashSet("ROLE_ADMIN");
     private String loginUrl;
     private String service;
     private Resource users;
@@ -34,11 +36,11 @@ public void setIp(final String ip) {
         this.ip = ip;
     }
 
-    public String getAdminRoles() {
+    public Set<String> getAdminRoles() {
         return adminRoles;
     }
 
-    public void setAdminRoles(final String adminRoles) {
+    public void setAdminRoles(final Set<String> adminRoles) {
         this.adminRoles = adminRoles;
     }
 

diff --git a/docs/cas-server-documentation/installation/Configuration-Properties.md b/docs/cas-server-documentation/installation/Configuration-Properties.md
@@ -275,7 +275,7 @@ To learn more about this topic, [please review this guide](Monitoring-Statistics
 # cas.adminPagesSecurity.loginUrl=https://sso.example.org/cas/login
 # cas.adminPagesSecurity.service=https://sso.example.org/cas/status/dashboard
 # cas.adminPagesSecurity.users=file:/etc/cas/config/adminusers.properties
-# cas.adminPagesSecurity.adminRoles=ROLE_ADMIN
+# cas.adminPagesSecurity.adminRoles[0]=ROLE_ADMIN
 
 # cas.adminPagesSecurity.actuatorEndpointsEnabled=true
 ```

diff --git a/...er-webapp-config/src/main/java/org/apereo/cas/config/CasSecurityContextConfiguration.java b/...er-webapp-config/src/main/java/org/apereo/cas/config/CasSecurityContextConfiguration.java
@@ -113,9 +113,7 @@ public Config config() {
                         final Properties properties = new Properties();
                         properties.load(file.getInputStream());
                         client.setAuthorizationGenerator(new SpringSecurityPropertiesAuthorizationGenerator(properties));
-                        cfg.setAuthorizer(new RequireAnyRoleAuthorizer(
-                                org.springframework.util.StringUtils.commaDelimitedListToSet(
-                                        casProperties.getAdminPagesSecurity().getAdminRoles())));
+                        cfg.setAuthorizer(new RequireAnyRoleAuthorizer(casProperties.getAdminPagesSecurity().getAdminRoles()));
                     }
                 }
                 return cfg;