Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to change password during auth warning if pm enabled #3016

Merged
merged 5 commits into from
Oct 20, 2017
Merged

Added ability to change password during auth warning if pm enabled #3016

merged 5 commits into from
Oct 20, 2017

Conversation

marwatk
Copy link
Contributor

@marwatk marwatk commented Oct 19, 2017

There didn't seem to be a way to allow users to change their password outside of the server spitting out a "must change" response. This PR adds a button on the authentication warning screen to change their password if pm is enabled.

Sorry for the extraneous edits to messages.properties, my editor killed trailing whitespace when adding screen.button.changePassword=Change Password. I figured I'd leave them since cleaner is better?

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ mmoayyed
❌ Marcus Watkins
❌ marwatk


Marcus Watkins seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mmoayyed
Copy link
Member

Excellent.

Before merging, let me ask: is this not what you need?
https://github.com/apereo/cas/blob/master/webapp/resources/templates/fragments/loginform.html#L89

@marwatk
Copy link
Contributor Author

marwatk commented Oct 20, 2017

That allows them to reset it by going through the reset flow (getting an email, answering questions, etc). But most of the time our users change it during the warnings like "Your password will expire in X days," before it actually expires, to avoid the whole security question rigmarole.

@mmoayyed
Copy link
Member

Ah of course. I failed to see the changes were in loginMessagesView. Sorry!

PS Could I ask you to reach to me privately either via email or gitter? I do have something I would like to discuss with you and see if that might spark an interest. I am at mmoayyed@unicon.net or @mmoayyed on Gitter. 100% optional :)

@mmoayyed mmoayyed merged commit 199e756 into apereo:master Oct 20, 2017
@mmoayyed
Copy link
Member

Sorry for the extraneous edits to messages.properties, my editor killed trailing whitespace when adding screen.button.changePassword=Change Password. I figured I'd leave them since cleaner is better?

Always, and I don't care that much :) All is good.

@mmoayyed mmoayyed added this to the 5.2.0 milestone Oct 20, 2017
@marwatk marwatk deleted the password-warning-change branch October 20, 2017 14:37
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 43.035% when pulling f50b0ac on marwatk:password-warning-change into ec23ef2 on apereo:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants