-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to change password during auth warning if pm enabled #3016
Conversation
Marcus Watkins seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Excellent. Before merging, let me ask: is this not what you need? |
That allows them to reset it by going through the reset flow (getting an email, answering questions, etc). But most of the time our users change it during the warnings like "Your password will expire in X days," before it actually expires, to avoid the whole security question rigmarole. |
Ah of course. I failed to see the changes were in PS Could I ask you to reach to me privately either via email or gitter? I do have something I would like to discuss with you and see if that might spark an interest. I am at mmoayyed@unicon.net or @mmoayyed on Gitter. 100% optional :) |
Always, and I don't care that much :) All is good. |
There didn't seem to be a way to allow users to change their password outside of the server spitting out a "must change" response. This PR adds a button on the authentication warning screen to change their password if pm is enabled.
Sorry for the extraneous edits to messages.properties, my editor killed trailing whitespace when adding
screen.button.changePassword=Change Password
. I figured I'd leave them since cleaner is better?