Couchbase v5 #3227
Merged
Couchbase v5 #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoayyed
reviewed
Feb 28, 2018
ci/run-couchbase-server-v5.sh
Outdated
| #while sleep 9m; do echo -e '\n=====[ Gradle build is still running ]====='; done & | ||
|
|
||
| echo "Pulling Couchbase docker image..." | ||
| docker pull couchbase/server:4.6.4 |
There was a problem hiding this comment.
@dima767 how did you validate against Couchbase 5? This is still pulling 4.6.4, no?
mmoayyed
reviewed
Feb 28, 2018
| docker pull couchbase/server:4.6.4 | ||
|
|
||
| echo "Running Couchbase docker image..." | ||
| docker run -d --name couchbase -p 8091-8094:8091-8094 -p 11210:11210 couchbase/server:5.1.0 |
There was a problem hiding this comment.
Ah, I see you're pulling/running the image here. Cool. Ignore comment :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified ticket registry and services registry against both v4 and v5 of Couchbase by making unit tests (integration tests against dockerized Couchbase instance) pass for both versions. No code changes required except the script for docker image to use password for bucket for v4 and user password for v5 (username added must match the bucket name in use), and unit tests to reflect the bucket names and passwords by adding additional properties values right inside the @SpringBootTest annotation.
The separate
ci/run-couchbase-server-v5.shis introduced, but I'm not sure how to incorporate that into the travis machinery, etc.