Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SpnegoWebflowConfigurer to use the evaluateClientRequest as documented #3408

Merged
merged 2 commits into from Jul 16, 2018
Merged

Conversation

miller79
Copy link
Contributor

Changes include the following:

  • Added conditional logic when mixedModeAuthentication is false to use
    startSpnegoAuthenticate flow. Otherwise it will use
    evaluateClientRequest.
  • Modified createEvaluateSpnegoClientAction to be equivlent to the other
    Spnego actions on failure which is
    CasWebflowConstants.STATE_ID_VIEW_LOGIN_FORM

Since this change fixes the documentation listed out here, this change re-enables the functionality which may cause unexpected results to those using the defaults. Some of those properties are the following:

  • cas.authn.spnego.hostNameClientActionStrategy
  • cas.authn.spnego.hostNamePatternString
  • cas.authn.spnego.mixedModeAuthentication
  • cas.authn.spnego.ipsToCheckPattern

I have done my best to ensure as few changes are affected as possible.

documented.

Changes include the following:
- Added conditional logic when mixedModeAuthentication is false to use
startSpnegoAuthenticate flow.  Otherwise it will use
evaluateClientRequest.
- Modified createEvaluateSpnegoClientAction to be equivlent to the other
Spnego actions on failure which is
CasWebflowConstants.STATE_ID_VIEW_LOGIN_FORM
@welcome
Copy link

welcome bot commented Jul 16, 2018

Thank you so much for opening your first pull request here!

@CLAassistant
Copy link

CLAassistant commented Jul 16, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mmoayyed mmoayyed merged commit dafccf4 into apereo:master Jul 16, 2018
@welcome
Copy link

welcome bot commented Jul 16, 2018

Congratulations on merging your first pull request here! 🎉 Excellent work! Keep'em coming.

@mmoayyed mmoayyed added this to the 6.0.0-RC1 milestone Jul 16, 2018
@mmoayyed
Copy link
Member

Thank you. Just in case, you may want to post the same patch to the 5.3.x branch as well specially if you wish to use this fix in the next 5.3 patch release.

@mmoayyed mmoayyed added the Bug label Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants