Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up password mgmt #3605

Closed
wants to merge 1 commit into from
Closed

clean up password mgmt #3605

wants to merge 1 commit into from

Conversation

tduehr
Copy link
Contributor

@tduehr tduehr commented Oct 15, 2018

No description provided.

@request-info
Copy link

request-info bot commented Oct 15, 2018

The maintainers of this repository would appreciate it if you could provide more information.

@tduehr tduehr force-pushed the cleanPm branch 3 times, most recently from 4a3ad04 to 2854456 Compare October 16, 2018 19:29
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #3605 into master will decrease coverage by 58.71%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #3605       +/-   ##
============================================
- Coverage     58.71%      0%   -58.72%     
============================================
  Files          1431    1413       -18     
  Lines         30302   30330       +28     
  Branches       2815    2823        +8     
============================================
- Hits          17791       0    -17791     
- Misses        10785   30330    +19545     
+ Partials       1726       0     -1726
Impacted Files Coverage Δ Complexity Δ
...g/apereo/cas/pm/JdbcPasswordManagementService.java 0% <ø> (ø) 0 <0> (?)
...g/apereo/cas/pm/RestPasswordManagementService.java 0% <ø> (ø) 0 <0> (?)
.../cas/pm/JsonResourcePasswordManagementService.java 0% <ø> (ø) 0 <0> (?)
...as/pm/GroovyResourcePasswordManagementService.java 0% <ø> (ø) 0 <0> (?)
...g/apereo/cas/pm/NoOpPasswordManagementService.java 0% <ø> (ø) 0 <0> (?)
...g/apereo/cas/pm/LdapPasswordManagementService.java 0% <0%> (-53.34%) 0 <0> (-6)
...tication/principal/TokenWebApplicationService.java 0% <0%> (-100%) 0% <0%> (-1%)
...rg/apereo/cas/adaptors/generic/CasUserAccount.java 0% <0%> (-100%) 0% <0%> (-1%)
...n/principal/PrincipalBearingPrincipalResolver.java 0% <0%> (-100%) 0% <0%> (-3%)
...hentication/principal/OpenIdPrincipalResolver.java 0% <0%> (-100%) 0% <0%> (-3%)
... and 1198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd21b36...e843273. Read the comment docs.

@stale
Copy link

stale bot commented Oct 24, 2018

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Pending label Oct 24, 2018
@mmoayyed mmoayyed modified the milestones: 6.0.0-RC3, 6.0.0-RC4 Oct 25, 2018
@stale stale bot removed Pending labels Oct 25, 2018
@stale
Copy link

stale bot commented Oct 30, 2018

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Pending label Oct 30, 2018
@stale
Copy link

stale bot commented Nov 6, 2018

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Pending label Nov 6, 2018
@stale
Copy link

stale bot commented Nov 11, 2018

This patch has been automatically closed because it has not had recent activity. If you wish to resume work, please re-open the pull request and continue as usual. Thank you for your contributions.

@stale stale bot closed this Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants