Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CAS to authenticate itself at the REST password management endpoints #3685

Merged
merged 6 commits into from Dec 30, 2018

Conversation

larsgrefer
Copy link
Contributor

@larsgrefer larsgrefer commented Dec 6, 2018

With this PR, CAS will support secured PM REST-Endpoints.

@request-info
Copy link

request-info bot commented Dec 6, 2018

The maintainers of this repository would appreciate it if you could provide more information.

@welcome
Copy link

welcome bot commented Dec 6, 2018

Thank you so much for opening your first pull request here!

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2018

CLA assistant check
All committers have signed the CLA.

@mmoayyed mmoayyed added this to the 6.1.0-RC1 milestone Dec 6, 2018
@larsgrefer
Copy link
Contributor Author

@mmoayyed Why has @apereocas-bot added this to the 6.1.0-RC1 milestone but #3686 was added to the 6.0.0 milestone?

@mmoayyed
Copy link
Member

mmoayyed commented Dec 6, 2018

The bot is out of order and isn't quite cognizant of the CAS release policy just yet. Given the final cut of RC4 and we more or less going into freeze mode, the targetted version should be 6.1.0-RC1. I'll take a pass later today to make the bot behave.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #3685 into master will decrease coverage by 54.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #3685       +/-   ##
============================================
- Coverage        61%   6.56%   -54.44%     
+ Complexity     6133     627     -5506     
============================================
  Files          1451    1141      -310     
  Lines         30900   24134     -6766     
  Branches       2867    2179      -688     
============================================
- Hits          18849    1585    -17264     
- Misses        10246   22380    +12134     
+ Partials       1805     169     -1636
Impacted Files Coverage Δ Complexity Δ
...thentication/principal/GroovyPrincipalFactory.java 0% <0%> (-100%) 0% <0%> (-2%)
.../fingerprint/DefaultDeviceFingerprintStrategy.java 0% <0%> (-100%) 0% <0%> (-2%)
...ereo/cas/web/flow/login/InitializeLoginAction.java 0% <0%> (-100%) 0% <0%> (-2%)
...uchdb/yubikey/YubiKeyAccountCouchDbRepository.java 0% <0%> (-100%) 0% <0%> (-2%)
...onfigurer/plan/DefaultCasWebflowExecutionPlan.java 0% <0%> (-100%) 0% <0%> (-5%)
...eb/flow/YubiKeyAccountCheckRegistrationAction.java 0% <0%> (-100%) 0% <0%> (-2%)
...n/java/org/apereo/cas/ticket/ExpirationPolicy.java 0% <0%> (-100%) 0% <0%> (-1%)
...cipher/WebflowConversationStateCipherExecutor.java 0% <0%> (-100%) 0% <0%> (-5%)
.../AuthenticationPasswordPolicyHandlingStrategy.java 0% <0%> (-100%) 0% <0%> (-2%)
...yThrottledSubmissionHandlerInterceptorAdapter.java 0% <0%> (-100%) 0% <0%> (-10%)
... and 1212 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6489a88...593b4bf. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #3685 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3685      +/-   ##
============================================
+ Coverage        61%   61.05%   +0.05%     
- Complexity     6133     6138       +5     
============================================
  Files          1451     1451              
  Lines         30900    30900              
  Branches       2867     2867              
============================================
+ Hits          18849    18865      +16     
+ Misses        10246    10227      -19     
- Partials       1805     1808       +3
Impacted Files Coverage Δ Complexity Δ
...reo/cas/couchbase/core/CouchbaseClientFactory.java 69.73% <0%> (-1.32%) 14% <0%> (-1%)
...ava/org/apereo/cas/util/io/PathWatcherService.java 66.66% <0%> (+31.48%) 11% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6489a88...17888aa. Read the comment docs.

@stale stale bot added Pending and removed Pending labels Dec 12, 2018
@apereo apereo deleted a comment from stale bot Dec 12, 2018
@stale
Copy link

stale bot commented Dec 17, 2018

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added Pending and removed Pending labels Dec 17, 2018
@stale
Copy link

stale bot commented Dec 22, 2018

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added Pending and removed Pending labels Dec 22, 2018
@stale
Copy link

stale bot commented Dec 30, 2018

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added Pending and removed Pending labels Dec 30, 2018
@mmoayyed mmoayyed merged commit 457f243 into apereo:master Dec 30, 2018
@welcome
Copy link

welcome bot commented Dec 30, 2018

Congratulations on merging your first pull request here! 🎉 Excellent work! Keep'em coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants